Introduce async actor transition utils#2782
Merged
Conversation
leolost2605
force-pushed
the
leolost/async-transition
branch
5 times, most recently
from
34b30e3 to
ab9e4bc
Compare
lenemter
force-pushed
the
leolost/async-transition
branch
from
ab9e4bc to
77d32a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing a bunch of manual work connecting to done signals of transitions use valas async syntax. Therefore introduce a transition builder that either sets the properties immediately or adds them to a transition and then allows to run it via an async method.
Then use it in the windowmanager map/destroy animations.
This should also fix a few corner cases where we were getting "Error in map accounting".