Skip to content

Introduce a wayland/x11 mutter hints protocol for monitor labels#2084

Merged
leolost2605 merged 1 commit intomainfrom
leolost/monitor-label-protocol
Apr 22, 2026
Merged

Introduce a wayland/x11 mutter hints protocol for monitor labels#2084
leolost2605 merged 1 commit intomainfrom
leolost/monitor-label-protocol

Conversation

@leolost2605
Copy link
Copy Markdown
Member

@leolost2605 leolost2605 commented Oct 12, 2024

Currently we do monitor labels quite awkardly. First the display plug has to go via dbus to the daemon having to send color info, monitor index, label, x, y then the daemon spawns the labels and then gala looks at the window title and positions the label.

This can be made properly now by just using a wayland protocol/ setting the mutter hints on x11.

Goes with elementary/pantheon-wayland#3 and elementary/settings-display#401

Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're in the stable release phase we can add new API but we can't break old API until the next major version bump

@leolost2605
Copy link
Copy Markdown
Member Author

Ah right that is a thing oops 😅
This isn't very important just a better and slightly improved way to do it so it's obviously fine to wait
I think I'll factor out the WindowPositioner and the corresponding fix for centered windows though and prepare a separate PR for that (which, TBH, it probably should be anyway)

@leolost2605 leolost2605 added the Blocked Something else needs to be done before this can be fixed label Oct 13, 2024
@lenemter lenemter added the Conflicts Has conflicts with the target branch label Jan 18, 2025
@danirabbit
Copy link
Copy Markdown
Member

@leolost2605 is it possible to add the new API without breaking the old API so we can move forward?

@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch from 9d7dc8b to 7861903 Compare March 16, 2025 15:17
@lenemter lenemter added this to OS 9 Jul 29, 2025
@lenemter lenemter moved this to Needs Review in OS 9 Jul 29, 2025
@lenemter lenemter moved this from Needs Review to In progress in OS 9 Jul 29, 2025
@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch from 7861903 to b9da554 Compare November 7, 2025 20:31
@leolost2605 leolost2605 removed Blocked Something else needs to be done before this can be fixed Conflicts Has conflicts with the target branch labels Nov 7, 2025
@leolost2605 leolost2605 moved this from In progress to Needs Review in OS 9 Nov 7, 2025
@leolost2605
Copy link
Copy Markdown
Member Author

@danirabbit finally got around to updating this so it should be ready without breaking the current API :)

@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch 2 times, most recently from b328a49 to b12d7b4 Compare November 7, 2025 21:06
@danirabbit danirabbit requested a review from a team November 11, 2025 16:52
@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch from b12d7b4 to edaf1f9 Compare November 13, 2025 11:13
@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch from edaf1f9 to edf29a8 Compare November 29, 2025 09:28
@danirabbit danirabbit removed this from OS 9 Dec 7, 2025
@danirabbit danirabbit moved this to Needs review in OS 8.1.1 Dec 7, 2025
@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch from edf29a8 to d1db999 Compare December 27, 2025 15:39
@danirabbit danirabbit removed this from OS 8.1.1 Jan 21, 2026
@danirabbit danirabbit added this to OS 9 Jan 21, 2026
@danirabbit danirabbit moved this to Needs Review in OS 9 Jan 21, 2026
@zeebok zeebok added the Conflicts Has conflicts with the target branch label Feb 6, 2026
@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch from 0919d3a to 0a23871 Compare March 4, 2026 14:23
@leolost2605 leolost2605 removed the Conflicts Has conflicts with the target branch label Mar 4, 2026
@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch 2 times, most recently from fc7589a to 37c2843 Compare March 9, 2026 16:31
@leolost2605 leolost2605 mentioned this pull request Mar 23, 2026
Copy link
Copy Markdown
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno what was here before that was breaking API but this code looks good to me

@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch from f4d281a to f509052 Compare April 21, 2026 14:36
@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch from f509052 to 76339ab Compare April 22, 2026 12:23
@leolost2605 leolost2605 force-pushed the leolost/monitor-label-protocol branch from 76339ab to 3de5fe5 Compare April 22, 2026 12:23
@leolost2605 leolost2605 dismissed danirabbit’s stale review April 22, 2026 12:26

No API break anymore

@leolost2605 leolost2605 merged commit 3c0c3fe into main Apr 22, 2026
6 checks passed
@leolost2605 leolost2605 deleted the leolost/monitor-label-protocol branch April 22, 2026 12:26
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants