Skip to content

Cleanup: FolderManager File object#1770

Merged
danirabbit merged 7 commits into
masterfrom
jeremypw/foldermanager/file-cleanup
Jul 20, 2026
Merged

Cleanup: FolderManager File object#1770
danirabbit merged 7 commits into
masterfrom
jeremypw/foldermanager/file-cleanup

Conversation

@jeremypw

@jeremypw jeremypw commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator
  • Inline namespace
  • Inline single use functions
  • Reorder to static, public, private members, create, construct, public methods, private methods
  • Make path construct only
  • Set GLib.File only in construct clause
  • Load info on construct, including executable attribute
  • Start to make naming less ambiguous

Comment thread src/FolderManager/File.vala
Comment thread src/FolderManager/File.vala
@jeremypw
jeremypw requested a review from danirabbit July 16, 2026 10:09
@jeremypw

Copy link
Copy Markdown
Collaborator Author

Changed the header for FolderItem too by mistake, but left it as it is needed anyway.

@danirabbit
danirabbit merged commit b09bd8e into master Jul 20, 2026
6 checks passed
@danirabbit
danirabbit deleted the jeremypw/foldermanager/file-cleanup branch July 20, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants