Skip to content

fix: add explicit AS aliases to all columns in get_tests & populate_test_alerts_query to support ClickHouse < 24.3 #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maanh96 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add explicit AS aliases to all columns in get_tests & populate_test_alerts_query to support ClickHouse < 24.3 #2231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions elementary/monitor/dbt_project/macros/alerts/population/test_alerts.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
)

select distinct
failed_tests.alert_id,
failed_tests.alert_id as alert_id,
{# Generate elementary unique id which is used to identify between tests, and set it as alert_class_id #}
{{ dbt.concat(["coalesce(failed_tests.test_unique_id, 'None')", "'.'", "coalesce(failed_tests.column_name, 'None')", "'.'", "coalesce(failed_tests.sub_type, 'None')"]) }} as alert_class_id,
case
Expand All @@ -135,39 +135,39 @@
when tests.short_name = 'dimension_anomalies' then failed_tests.test_unique_id
else {{ dbt.concat(["coalesce(failed_tests.test_unique_id, 'None')", "'.'", "coalesce(failed_tests.column_name, 'None')", "'.'", "coalesce(failed_tests.sub_type, 'None')"]) }}
end as elementary_unique_id,
failed_tests.data_issue_id,
failed_tests.test_execution_id,
failed_tests.test_unique_id,
failed_tests.model_unique_id,
failed_tests.data_issue_id as data_issue_id,
failed_tests.test_execution_id as test_execution_id,
failed_tests.test_unique_id as test_unique_id,
failed_tests.model_unique_id as model_unique_id,
{# Explicit aliases for columns that exist in both failed_tests and tests tables to avoid ClickHouse column name ambiguity #}
failed_tests.database_name as database_name,
failed_tests.detected_at,
failed_tests.detected_at as detected_at,
{{ elementary.edr_current_timestamp() }} as created_at,
failed_tests.schema_name as schema_name,
failed_tests.table_name,
failed_tests.column_name,
failed_tests.table_name as table_name,
failed_tests.column_name as column_name,
failed_tests.test_type as alert_type,
failed_tests.sub_type,
failed_tests.sub_type as sub_type,
failed_tests.test_results_description as alert_description,
failed_tests.owners,
failed_tests.owners as owners,
failed_tests.tags as tags,
failed_tests.test_results_query as alert_results_query,
failed_tests.other,
failed_tests.test_name,
failed_tests.test_short_name,
failed_tests.other as other,
failed_tests.test_name as test_name,
failed_tests.test_short_name as test_short_name,
failed_tests.test_params as test_params,
failed_tests.severity as severity,
failed_tests.status as status,
failed_tests.result_rows as result_rows,
tests.meta as test_meta,
tests.description as test_description,
artifacts_meta.meta as model_meta,
invocations.job_id,
invocations.job_name,
invocations.job_run_id,
invocations.job_url,
invocations.job_run_url,
invocations.orchestrator
invocations.job_id as job_id,
invocations.job_name as job_name,
invocations.job_run_id as job_run_id,
invocations.job_url as job_url,
invocations.job_run_url as job_run_url,
invocations.orchestrator as orchestrator
from failed_tests
left join tests on failed_tests.test_unique_id = tests.unique_id
left join artifacts_meta on failed_tests.model_unique_id = artifacts_meta.unique_id
Expand Down
18 changes: 9 additions & 9 deletions elementary/monitor/dbt_project/macros/get_tests.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,22 +65,22 @@
select
tests.unique_id as unique_id,
tests.parent_model_unique_id as model_unique_id,
tests.database_name,
tests.schema_name,
tests.database_name as database_name,
tests.schema_name as schema_name,
nodes.name as model_name,
tests.test_column_name as column_name,
tests.name as name,
tests.description,
tests.package_name,
tests.original_path,
tests.test_params,
tests.description as description,
tests.package_name as package_name,
tests.original_path as original_path,
tests.test_params as test_params,
tests.meta as meta,
nodes.meta as model_meta,
tests.tags,
tests.tags as tags,
nodes.tags as model_tags,
tests.type as type,
last_test_results.test_type,
last_test_results.test_sub_type,
last_test_results.test_type as test_type,
last_test_results.test_sub_type as test_sub_type,
test_results_times.first_detected_at as created_at,
last_test_results.detected_at as latest_run_time,
last_test_results.status as latest_run_status
Expand Down
Loading