Fix emoji verification for RTL languages #8237

[pt2121]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

As mentioned in #8237, the emojis are in a wrong order in RTL.

Screenshots / GIFs

Screenshots on the left are from the web in English (RTL) and ones on the right are from LTR languages.

Tests

1. Change phone language to Hebrew or RTL languages
2. Go through the verification using emoji
3. Compare the emojis

Tested devices

• Physical
• Emulator
• OS version(s): Android 5, 11 and 12

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[jmartinesp]

LGTM, thanks!

[BillCarsonFr]

Hold on.
Need to think a bit more on that one, because if you actually spell out loud the emojis you will get the correct order. If we fix the order, we would have to update the text to say in what order it should be read

[pt2121]

we would have to update the text to say in what order it should be read

Sorry, I am not sure I follow. Can you elaborate?
With this fix, the emojis would be read the same whether the user reads from RTL or LTR. Isn't that what we want?

[jmartinesp]

we would have to update the text to say in what order it should be read

Sorry, I am not sure I follow. Can you elaborate? With this fix, the emojis would be read the same whether the user reads from RTL or LTR. Isn't that what we want?

The UI says 'ensure they appear in the same order', but wouldn't a RTL user read the emojis from right to left? In that case, the 'first' one in LTR would be the leftmost one and in RTL the rightmost one, right? I'm not a RTL user myself, so I'm not sure if that's the case.

[pt2121]

I see the point now. I'm wondering how we handle this on iOS and web.
I sort of assume the same user would casually see that emojis look the same regardless of what language is set but I could be really wrong here. 😅

This is an interesting UX question.

Edited: Just checked this in Persian on iOS, fwiw, with this change, the emoji would in the same order on iOS and Android.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}