Bluetooth-assisted Push to Talk (PTT) via Element Call by onurays · Pull Request #6464 · element-hq/element-android

onurays · 2022-07-05T09:30:20Z

This is a proof-of-concept implementation of hardware-supported Push-to-Talk (PTT) using Element Call in a widget.

Experimental proof-of-concept (PoC); not fit for general use
Replaces native 1on1 calls (temporary shortcut)
Only works with specific Bluetooth PTT buttons

ptt_bottomsheet.mp4

github-actions · 2022-07-05T09:34:18Z

Ktlint Results

👎Failed
vector 🔸 features/widgets/ptt/BluetoothLowEnergyService.kt:19:1: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end (import-ordering)

sonarqubecloud · 2022-07-05T10:38:28Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

Johennes · 2022-07-05T12:19:55Z

vector/src/main/java/im/vector/app/features/widgets/WidgetFragment.kt

        }
    }

-    override fun onPause() {


Do we possibly want to keep this for non-Element-Call widgets?

Exactly, it is in my to-do list. Nice catch though, thanks.

onurays · 2022-07-05T13:34:11Z

vector/src/main/java/im/vector/app/features/widgets/ptt/BluetoothLowEnergyService.kt

+
+    override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
+        val notification = notificationUtils.buildBluetoothLowEnergyNotification()
+        startForeground(Random.nextInt(), notification)


We need to kill the service when the WidgetFragment is destroyed.

We should also disconnect from the bluetooth device which it looks like we might not be doing currently

by setting the appropriate descriptor, which apparently is not a thing that setCharacteristicNotification does

Enable notifications for characteristic changes

onurays · 2022-07-06T15:53:12Z

vector/src/main/java/im/vector/app/features/widgets/WidgetFragment.kt

+
+            override fun onScanResult(device: BluetoothDevice) {
+                Timber.d("### WidgetFragment. New BLE device found: " + device.name + " - " + device.address)
+                if (device.name == null || bluetoothDevices.map { it.address }.contains(device.address)) {


This kind of logic and even this method should not be in the fragment if we want to merge this into the develop at one point.

onurays · 2022-07-06T15:55:13Z

vector/src/main/java/im/vector/app/features/widgets/ptt/BluetoothLowEnergyDeviceScanner.kt

+        bluetoothManager
+                ?.adapter
+                ?.bondedDevices
+                ?.firstOrNull { it.name == "PTT-Z" }


We should improve the UX with extra screens to get rid of the hardcoded device name.

onurays · 2022-07-06T15:55:33Z

vector/src/main/java/im/vector/app/features/widgets/ptt/BluetoothLowEnergyService.kt

+        override fun onServicesDiscovered(gatt: BluetoothGatt, status: Int) {
+            gatt.services.forEach { service ->
+                service.characteristics.forEach { characteristic ->
+                    if (characteristic.uuid.equals(UUID.fromString("0000ffe1-0000-1000-8000-00805f9b34fb"))) {


We should improve the UX with extra screens to get rid of the hardcoded uuid.

onurays · 2022-07-06T15:55:42Z

vector/src/main/java/im/vector/app/features/widgets/ptt/BluetoothLowEnergyService.kt

+                service.characteristics.forEach { characteristic ->
+                    if (characteristic.uuid.equals(UUID.fromString("0000ffe1-0000-1000-8000-00805f9b34fb"))) {
+                        gatt.setCharacteristicNotification(characteristic, true)
+                        val descriptor = characteristic.getDescriptor(UUID.fromString("00002902-0000-1000-8000-00805f9b34fb"))


We should improve the UX with extra screens to get rid of the hardcoded uuid.

Signed-off-by: Johannes Marbach <johannesm@element.io>

Suppress webview / checkbox permission dialog

sonarqubecloud · 2022-11-04T21:06:51Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

0.0% Coverage
0.0% Duplication

bmarty · 2023-01-10T13:52:16Z

@onurays what is the status of the PR?

Johennes · 2023-01-10T13:55:35Z

@onurays what is the status of the PR?

@bmarty We don't plan on merging this in the near future but would like to be able to have the ability to build APKs off of the branch for customer demos. So unless the PR creates any issues, it'd be very helpful if we could keep it alive.

The old one has disappeared from Netlify. This replaces it with a ROSA deployment like our live EC which shouldn't randomly go away.

Update to new Element Call URL

…feature/ons/ptt_bluetooth

…eature/ons/ptt_bluetooth

Allow events to be collected in the background

Start Element Call widget in its own task So that closing the app does not end a PTT call

ElementBot · 2023-01-25T14:39:39Z

vector/src/main/java/im/vector/app/features/widgets/WidgetFragment.kt

 package im.vector.app.features.widgets

 import android.app.Activity
+import android.bluetooth.BluetoothDevice


🚫 Unused import

ElementBot · 2023-01-25T14:39:39Z

vector/src/main/java/im/vector/app/features/widgets/WidgetFragment.kt

 import im.vector.app.features.settings.VectorPreferences
 import im.vector.app.features.webview.WebEventListener
+import im.vector.app.features.widgets.ptt.BluetoothLowEnergyDevice
+import im.vector.app.features.widgets.ptt.BluetoothLowEnergyDeviceScanner


🚫 Unused import

ElementBot · 2023-01-25T14:39:40Z

vector/src/main/java/im/vector/app/features/widgets/WidgetViewModel.kt

 import org.matrix.android.sdk.flow.mapOptional
 import org.matrix.android.sdk.flow.unwrap
 import timber.log.Timber
+import javax.inject.Inject


🚫 Unused import

sonarqubecloud · 2023-01-25T15:15:35Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

2.1% Coverage
0.0% Duplication

CLAassistant · 2024-09-25T12:58:19Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 4 committers have signed the CLA.

❌ Onuray Sahin
❌ onurays
❌ Johennes
❌ jonnyandrew

Onuray Sahin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

onurays added 8 commits July 4, 2022 13:53

Add element call widget type.

f538e91

Create BLE service.

022ae91

Add required bluetooth permissions.

09c435a

Create custom widget args for element call.

cf8056e

Scan available BLE devices and show in a dialog.

35dad02

Create a sticky service for BLE communication.

7e152bd

Add LE flag to gatt connection.

715459a

Register to all characteristics.

dd72201

onurays added 2 commits July 5, 2022 13:57

Emit ByteArray instead of hex.

096fd83

Create a post message when receiving expected ptt data.

4b128d3

Johennes reviewed Jul 5, 2022

View reviewed changes

Support picture-in-picture mode for element call widget.

10d1325

onurays commented Jul 5, 2022

View reviewed changes

dbkr and others added 8 commits July 5, 2022 18:10

Enable notifications for characteristic changes

9ef20f4

by setting the appropriate descriptor, which apparently is not a thing that setCharacteristicNotification does

Request required bluetooth permission.

13b3178

Merge pull request #6476 from vector-im/dbkr/ptt_enable_notifications

cea7193

Enable notifications for characteristic changes

Skip widget permissions for element call.

75ab0ae

Auto grant WebView permissions if they are already granted system level.

9090e37

Open element call widget directly if it is the only widget.

cf4d2ed

Auto-connect to ptt-z devices.

e53a644

Fix device name.

039a8d1

onurays commented Jul 6, 2022

View reviewed changes

Johennes and others added 3 commits July 7, 2022 08:46

Suppress webview / checkbox permission dialog

d955e15

Signed-off-by: Johannes Marbach <johannesm@element.io>

Merge pull request #6494 from vector-im/johannes/shortcut-permissions

ed1b861

Suppress webview / checkbox permission dialog

Stop javascript for non element call widgets.

b5d312e

Onuray Sahin added 7 commits October 25, 2022 15:42

Refactor deprecated methods.

9b87f83

Revert code to support devices below Android 12.

39fa999

Reconnect to the ptt button automatically.

dd49baf

Support Android 12 and above.

706f513

Implement bluetooth device list bottom sheet.

b3b5a5b

Connect bluetooth device from bottom sheet.

84dca45

Fix service connection on Android 12.

8973199

Johennes changed the title ~~Push to Talk Gatt Client Implementation~~ Bluetooth-assisted Push to Talk (PTT) via Element Call Nov 8, 2022

jonnyandrew and others added 7 commits January 17, 2023 16:48

Force voice call button to trigger new flow

8f7e2b9

Update to new Element Call URL

f98339c

The old one has disappeared from Netlify. This replaces it with a ROSA deployment like our live EC which shouldn't randomly go away.

Merge pull request #7980 from vector-im/dbkr/change_ec_url

520eb2c

Update to new Element Call URL

Update app name and logo color for demo

83355a7

Start foreground service asap.

6bfe3ff

Merge remote-tracking branch 'origin/feature/ons/ptt_bluetooth' into …

67e391a

…feature/ons/ptt_bluetooth

Add logs to debug.

f872844

jonnyandrew mentioned this pull request Jan 24, 2023

[PTT] Fix element call UI touchable through bottom sheet #7997

Merged

15 tasks

jonnyandrew and others added 6 commits January 24, 2023 16:30

Fix element call UI touchable through bottom sheet (#7997)

4c46b44

Merge branch 'develop' of github.com:vector-im/element-android into f…

b552690

…eature/ons/ptt_bluetooth

Revert widget event observer behaviour

099be64

Allow events to be collected in the background

Fix duplicate bluetooth button events

e388b5f

Match any devices with 'kodiak' in the name

f9d44ed

Just connect to any paired devices with ptt in the name

a7ec054

jonnyandrew mentioned this pull request Jan 25, 2023

[PTT] Start Element Call widget in its own task #8004

Merged

15 tasks

Start Element Call widget in its own task (#8004)

4cbf692

Start Element Call widget in its own task So that closing the app does not end a PTT call

ElementBot reviewed Jan 25, 2023

View reviewed changes

Conversation

onurays commented Jul 5, 2022 • edited by MadLittleMods Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ktlint Results

Uh oh!

sonarqubecloud bot commented Jul 5, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 4, 2022

Uh oh!

bmarty commented Jan 10, 2023

Uh oh!

Johennes commented Jan 10, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 25, 2023

Uh oh!

CLAassistant commented Sep 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

onurays commented Jul 5, 2022 •

edited by MadLittleMods

Loading

github-actions bot commented Jul 5, 2022 •

edited

Loading

CLAassistant commented Sep 25, 2024 •

edited

Loading