Skip to content

feat(plugin-vite): upgrade vite 8 #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erickzhao merged 8 commits into from
Apr 9, 2026
Merged

feat(plugin-vite): upgrade vite 8 #4167

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8265f0f
feat(plugin-vite): upgrade vite to version 8.0.0
0xlau Mar 15, 2026
910bdc7
revert lockfile
erickzhao Mar 17, 2026
36e30ac
re-apply lockfile changes
erickzhao Mar 17, 2026
8a51cd9
Merge branch 'next' into vite/upgrade-v8
erickzhao Mar 18, 2026
eccb182
Merge branch 'next' into vite/upgrade-v8
erickzhao Apr 2, 2026
03da869
Merge branch 'next' into vite/upgrade-v8
erickzhao Apr 7, 2026
5db96f7
reset lockfile post-merge conflict
erickzhao Apr 7, 2026
34aaf6b
re-apply minimal yarn.lock diff
erickzhao Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"source-map-support": "^0.5.13",
"tsx": "^4.21.0",
"username": "^5.1.0",
"vite": "^7.2.4",
"vite": "^8.0.0",
"webpack": "^5.69.1",
"webpack-dev-server": "^4.0.0",
"webpack-merge": "^5.7.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/vite/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"@electron/packager": "^19.0.1",
"@malept/cross-spawn-promise": "^2.0.0",
"@types/node": "^22.10.7",
"vite": "^7.2.4",
"vite": "^8.0.0",
"vitest": "^4.0.14",
"which": "^2.0.2",
"xvfb-maybe": "^0.2.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/vite/spec/subprocess-worker.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ describe('subprocess-worker', () => {
const outFile = path.join(viteOutDir, 'build', 'main-with-define.js');
const contents = fs.readFileSync(outFile, 'utf8');
// MAIN_WINDOW_VITE_NAME should be statically replaced with "main_window"
expect(contents).toContain('"main_window"');
expect(contents).toMatch(/["'`]main_window["'`]/);
Copy link
Copy Markdown
Member

@erickzhao erickzhao Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this map to some breaking change in Vite 7 -> 8?

expect(contents).not.toContain('MAIN_WINDOW_VITE_NAME');
});

Expand Down
2 changes: 1 addition & 1 deletion packages/template/vite-typescript/tmpl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
"eslint-plugin-import": "^2.25.0",
"eslint-import-resolver-typescript": "^4.4.4",
"typescript": "^5.9.2",
"vite": "^7.2.4"
"vite": "^8.0.0"
}
}
2 changes: 1 addition & 1 deletion packages/template/vite/tmpl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"devDependencies": {
"@electron/fuses": "^2.0.0",
"@electron-forge/plugin-vite": "ELECTRON_FORGE/VERSION",
"vite": "^7.2.4"
"vite": "^8.0.0"
}
}
Loading
Loading