fix: properly quote Python command in depot_tools check#866
Open
dsanders11 wants to merge 1 commit into
Open
Conversation
ckerr
reviewed
May 22, 2026
| config, | ||
| 'python3', | ||
| ['-c', 'from gclient_paths import GetBuildtoolsPath; print(GetBuildtoolsPath() or "")'], | ||
| ['-c', process.platform === 'win32' ? `"${pythonCommand}"` : pythonCommand], |
Member
There was a problem hiding this comment.
Is the platform check needed? Seems like it would be less work + safer to always quote it
Member
Author
There was a problem hiding this comment.
Not necessary, but I was opting for the least amount of change to avoid unintentionally breaking anything else. 😅 This code is temporary and will be pulled out in a few months anyway, so was opting to only change the already broken code path. Should be fine to do on all platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check to see if we have a new enough
depot_toolsto not needCHROMIUM_BUILDTOOLS_PATHwasn't working on Windows because the Python command needs to be properly quoted.