fix: use siso for chrome target instead of reclient#768
fix: use siso for chrome target instead of reclient#768mitchchn wants to merge 2 commits intoelectron:mainfrom
Conversation
dsanders11
changed the title
dsanders11
left a comment
dsanders11
left a comment
There was a problem hiding this comment.
Updated the title to pass the semantic PR title check.
I think we probably want to just rip out the reclient stuff all together soon, but since that's going to be a large PR, I'm happy to accept this small focused change for now. 👍
jkleinsc
left a comment
jkleinsc
left a comment
There was a problem hiding this comment.
That I know of siso still uses the reclient configs, so we should still leave this code in.
jkleinsc
left a comment
jkleinsc
left a comment
There was a problem hiding this comment.
We still need the reclient_cfgs, they are referenced in siso configs: https://source.chromium.org/chromium/chromium/src/+/main:build/config/siso/clang_windows.star;l=33?q=build%2Fconfig%2Fsiso%2Fclang_windows.star&ss=chromium
|
Is there anything this PR needs now? |
|
I don't think this really works properly so I'm closing it. |
5 participants
No description provided.