Fix CMake compile definition leakage#687
Open
Alloyed wants to merge 1 commit intoelectro-smith:masterfrom
Open
Fix CMake compile definition leakage#687Alloyed wants to merge 1 commit intoelectro-smith:masterfrom
Alloyed wants to merge 1 commit intoelectro-smith:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My CI build was failing, and near as I can tell it's because I declare my targets, then import libdaisy. so the add_compile_definitions doesn't end up applying to my targets. marking it as public like this makes it transitive, so anybody that links to libdaisy also has this compile definition.
from my CI: