Add optional conversion complete callback to AdcHandle::Start()#632
Open
TheSlowGrowth wants to merge 1 commit intoelectro-smith:masterfrom
Open
Conversation
TheSlowGrowth
force-pushed
the
feature/TSG/adc-conversion-complete-callback
branch
from
4fdf54c to
29be422
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "conversion complete" callback to the
AdcHandlesimilar to the ones found in other drivers.This would allow users to actually know when a conversion is complete, as opposed to blindly reading the data off the
AdcHandlewithout knowing if it's actually new.A different solution would be to provide a "running counter" that increments on each completed conversion, as a means of identifying from the outside that new data is available.
This PR is just a proposal, of course. Happy to discuss other approaches!