Update daisy_patch_sm.cpp DacHandle::BufferState::DISABLED;#630
Open
IC-Alchemy wants to merge 1 commit intoelectro-smith:masterfrom
Open
Update daisy_patch_sm.cpp DacHandle::BufferState::DISABLED;#630IC-Alchemy wants to merge 1 commit intoelectro-smith:masterfrom
IC-Alchemy wants to merge 1 commit intoelectro-smith:masterfrom
Conversation
Removed redundant internal DAC buffer. Increases DAC range by around 0.4 Volts Allows for the full 0.0v - 3.3v range. "With internal buffer on, the min DAC_OUT is 0.2V and max DAC_OUT is VDDA-0.2V" Page 163 https://www.st.com/resource/en/datasheet/stm32h750ib.pdf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specific to the Patch_SM, only changed one line of code.
DacHandle::BufferState::DISABLED;Increases DAC output range to 0.0v - VREF
Quiet a few people believe that this cannot be done it seems.