Converted variable names to upper case before merging#2
Open
cimentadaj wants to merge 1 commit intoeldafani:masterfrom
Open
Converted variable names to upper case before merging#2cimentadaj wants to merge 1 commit intoeldafani:masterfrom
cimentadaj wants to merge 1 commit intoeldafani:masterfrom
Conversation
Before rbinding and subsetting arbitrary columns, I converted each countries variable names to upper case. This was crashing because some country variable names were lower case.
|
Hi, Fehler in sum(sapply(seq_along(pvnames), function(i) (PV.mean[i] - MEAN.m)^2)) : Any ideas? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Sorry for the previous pull request. It was a bit disorganized and in Spanish (which for some reason I thought both maintainers spoke).
Working with TIMSS 2007 G8, running a call like this one
timssg8.select.merge(folder = folder, student = c("BSBGMFED", "BSBGFMED"))yields an errorundefined columns. The problem is after running lines 84-85 (from your unmodified code) that reads the SPSS data sets. If you were to inspect the function line by line with the data manually, right after lines 84-85, running thissapply(junk0, function(x) all(tolower(names(x) == names(x))))will show you that Austria has all variable names in lower case whereas all other countries have upper case. This was throwing the error of undefined columns because the subset columns are always provided in upper case.I added lines 84-87 (in my pull request) that simply transforms all country variable names into upper case. The other changes (lines 74-90) are simply a reordering of the code. I also did the upper case transformation for the home and school data as well. This should also be applied to the teacher data. Whenever I have some time I plan to take care of that as well.