Open
Conversation
Owner
|
Thanks for your contributions, @bueltge! Unfortunately, I have very little time at the moment. I'm not familiar with Palm, what is it supposed to do? |
Author
|
Hey @elcobvg example |
…ot strict in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Thanks a lot of the Dropin, fine solution.
I fix two topics inside the code to get more solid usage and add more solid source code to maintain easier. I enhance also the composer.json to use them via composer workflow and add the necessary dependencies.
Small hint in content of method
incr(). I mean you should return only one type of return type, in your case Integer. Maybe you should remove thefalseand use0as value for failures.Best regards