Skip to content

update release changelog with docs-builder#1047

Open
SylvainJuge wants to merge 6 commits intomainfrom
changelog-release
Open

update release changelog with docs-builder#1047
SylvainJuge wants to merge 6 commits intomainfrom
changelog-release

Conversation

@SylvainJuge
Copy link
Copy Markdown
Member

  • generates changelog bundle on release
  • remove changelog individual entries on release
  • cleanup of unused code

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

📋 Changelog

⚠️ Cannot generate changelog: no matching type label found on this PR.

🔖 Add one of these type labels to your PR:

Label Type
breaking-change breaking-change
bug bug-fix
deprecation deprecation
feature feature
enhancement enhancement
changelog:upstream-update enhancement
docs docs
documentation docs

🔖 To skip changelog generation or configure label rules, see docs/changelog.yml.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

🔍 Preview links for changed docs

profiles:
edot-java-release:
products: "edot-java {version} {lifecycle}"
products: "edot-java * *"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[for reviewer] this makes the profile match all the changelog entries for edot-java for any version (as the changelog entries themselves do not have a target field set).

--title "${PR_TITLE}" \
--type enhancement \
--prs "${PR_URL}" \
--products "edot-java NEXT ga" \
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting the {version} as NEXT is not needed, nor is the 3rd element of the product definition, the edot-java-release profile will match all the changelog entries in the docs/changelog/ folder.

@SylvainJuge SylvainJuge marked this pull request as ready for review April 9, 2026 15:40
@SylvainJuge SylvainJuge requested review from a team as code owners April 9, 2026 15:40
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7482964-04ee-4b31-a8ee-0427e1be3a20

📥 Commits

Reviewing files that changed from the base of the PR and between ac4b775 and 5faef99.

📒 Files selected for processing (1)
  • .github/workflows/release-step-3.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/release-step-3.yml

📝 Walkthrough

Walkthrough

The change migrates changelog and release-notes generation from a custom Java tool and a Gradle task to an Elastic docs‑builder workflow. It deletes the Java CLI (ReleaseChangelog.java) and the printUpstreamDependenciesMarkdown Gradle task, clears CHANGELOG.md and CHANGELOG.next-release.md, updates GitHub Actions to run docs-builder commands to bundle and render changelogs, adjusts a CI script product argument, and modifies docs/changelog.yml to use wildcarded product/lifecycle selection with an output_products override.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch changelog-release
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/release-step-3.yml:
- Around line 228-237: The workflow is rendering a non-existent input and
leaving output redirections unquoted; update the docs-builder invocation to use
the real release YAML path docs-builder changelog render --input
"./docs/releases/${version}.yaml" --output "${tmp}", and quote all
$GITHUB_OUTPUT uses and any redirect expansions (replace >> $GITHUB_OUTPUT with
>> "$GITHUB_OUTPUT" and the initial echo 'notes<<RELNOTESEOF' >> $GITHUB_OUTPUT
with echo 'notes<<RELNOTESEOF' >> "$GITHUB_OUTPUT"), keeping existing
"${tmp}/${version}/index.md" and sed pipelines intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5ff9724e-d970-4d6a-9ef6-045c1acc6b05

📥 Commits

Reviewing files that changed from the base of the PR and between b100c12 and ac4b775.

📒 Files selected for processing (8)
  • .ci/ReleaseChangelog.java
  • .ci/changelog-upstream-update.sh
  • .github/workflows/pre-post-release.yml
  • .github/workflows/release-step-3.yml
  • CHANGELOG.md
  • CHANGELOG.next-release.md
  • build.gradle.kts
  • docs/changelog.yml
💤 Files with no reviewable changes (4)
  • CHANGELOG.next-release.md
  • CHANGELOG.md
  • build.gradle.kts
  • .ci/ReleaseChangelog.java

uses: ./.github/workflows/gradle-goal
with:
command: ""
- name: Docs builder setup
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical workflows/release-step-3.yml:224

The docs-builder changelog render command receives a non-existent path as --input. The ${tmp}/${{ env.RELEASE_VERSION }} directory is freshly created by mktemp -d and empty — no bundle file is copied there before the render command. This causes the command to fail with "Bundle file does not exist", breaking the generate-release-notes job and blocking downstream release steps. Consider copying the bundle YAML file to the temp directory before invoking docs-builder, or pass the correct path to the existing bundle file.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file .github/workflows/release-step-3.yml around line 224:

The `docs-builder changelog render` command receives a non-existent path as `--input`. The `${tmp}/${{ env.RELEASE_VERSION }}` directory is freshly created by `mktemp -d` and empty — no bundle file is copied there before the render command. This causes the command to fail with "Bundle file does not exist", breaking the `generate-release-notes` job and blocking downstream release steps. Consider copying the bundle YAML file to the temp directory before invoking `docs-builder`, or pass the correct path to the existing bundle file.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is created by docs-builder, this is why it does not exist before invocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant