Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/jobs/e2e-testing-helm-daily-mbp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
scm:
- github:
branch-discovery: no-pr
head-filter-regex: '(main|8\.\d|7\.17|feature-.*)'
head-filter-regex: '(main|PR-.*|8\.\d|7\.17|feature-.*)'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no here

discover-pr-forks-strategy: merge-current
discover-pr-forks-trust: permission
discover-pr-origin: merge-current
Expand Down
9 changes: 6 additions & 3 deletions .ci/jobs/e2e-testing-mbp.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a new job from scratch

- job:
name: e2e-tests/e2e-testing-mbp
display-name: End-2-End Tests Pipeline
description: Jenkins pipeline for the e2e-testing project
display-name: End-2-End Tests Pipeline for external calls
description: This pipeline can be only called from other repositories
view: E2E
project-type: multibranch
logrotate:
Expand All @@ -13,8 +13,11 @@
script-path: .ci/Jenkinsfile
scm:
- github:
property-strategies:
all-branches:
- suppress-scm-triggering: true
branch-discovery: no-pr
head-filter-regex: '(main|PR-.*|8\.\d+|7\.17|feature-.*)'
head-filter-regex: '(main|8\.\d+|7\.17|feature-.*)'
Copy link
Copy Markdown
Contributor

@kuisathaverat kuisathaverat Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes the current behavior on the stable branch without a change in the pipelines, this breaks the CI. the PR will not be processed until all new pipelines are develop.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A proposal here, do not touch the main pipeline (.ci/jobs/e2e-testing-mbp.yml) until everything is working. So, create a new file like this one with a different job.name, and use it until you have a process refined and working. For that, you will have to limit the head-filter-regex to a specific branch(where you are working) and PR (only your test PRs). then we can see which changes we can incorporate on the main branch without issues.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WYT @v1v

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuisathaverat Great solution! Could you please take a look now?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still making changes in .ci/jobs/e2e-testing-mbp.yml that is something we do not want

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limit the branches to your working branches and PRs

discover-pr-forks-strategy: merge-current
discover-pr-forks-trust: permission
discover-pr-origin: merge-current
Expand Down
46 changes: 46 additions & 0 deletions .ci/jobs/e2e-testing-pr-mbp.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
---
- job:
name: e2e-tests/e2e-testing-pr-mbp
display-name: End-2-End Tests Pull Request
description: e2e-testing pull requests builds
view: E2E
project-type: multibranch
logrotate:
daysToKeep: 30
numToKeep: 100
number-to-keep: 100
days-to-keep: 30
script-path: .ci/pull-request.groovy
scm:
- github:
branch-discovery: no-pr
# head-filter-regex: '(PR-.*)'
head-filter-regex: '(PR-3169)'
discover-pr-forks-strategy: merge-current
discover-pr-forks-trust: permission
discover-pr-origin: merge-current
discover-tags: false
notification-context: 'beats-ci/e2e-testing-pr'
repo: e2e-testing
repo-owner: elastic
credentials-id: 2a9602aa-ab9f-4e52-baf3-b71ca88469c7-UserAndToken
ssh-checkout:
credentials: f6c7695a-671e-4f4f-a331-acdce44ff9ba
build-strategies:
- change-request:
ignore-target-only-changes: true
clean:
after: true
before: true
prune: true
shallow-clone: true
depth: 4
do-not-fetch-tags: true
submodule:
disable: false
recursive: true
parent-credentials: true
timeout: 120
timeout: '15'
use-author: true
wipe-workspace: 'True'
46 changes: 46 additions & 0 deletions .ci/jobs/e2e-testing-pr-merge-mbp.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
---
- job:
name: e2e-tests/e2e-testing-pr-mbp
display-name: End-2-End Tests Pull Request Merge
description: Triggered when we merge a PR to main branches
view: E2E
project-type: multibranch
logrotate:
daysToKeep: 30
numToKeep: 100
number-to-keep: 100
days-to-keep: 30
script-path: .ci/pr-merge.groovy
scm:
- github:
branch-discovery: no-pr
# head-filter-regex: '(main|8\.\d+|7\.17)'
head-filter-regex: '(PR-3169)'
discover-pr-forks-strategy: merge-current
discover-pr-forks-trust: permission
discover-pr-origin: merge-current
discover-tags: true
notification-context: 'beats-ci/e2e-testing-pr-merge'
repo: e2e-testing
repo-owner: elastic
credentials-id: 2a9602aa-ab9f-4e52-baf3-b71ca88469c7-UserAndToken
ssh-checkout:
credentials: f6c7695a-671e-4f4f-a331-acdce44ff9ba
build-strategies:
- change-request:
ignore-target-only-changes: true
clean:
after: true
before: true
prune: true
shallow-clone: true
depth: 4
do-not-fetch-tags: true
submodule:
disable: false
recursive: true
parent-credentials: true
timeout: 120
timeout: '15'
use-author: true
wipe-workspace: 'True'