eck webhook default value clarified#6734
Conversation
Elastic Docs AI PR menuCheck the box to run an AI review for this pull request.
Powered by GitHub Agentic Workflows and docs-actions. For more information, reach out to the docs team. |
🔍 Preview links for changed docs |
Vale Linting ResultsSummary: 2 suggestions found 💡 Suggestions (2)
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
| | `webhook-port` | 9443 | Port to listen for incoming validation requests. | | ||
|
|
||
| :::::{note} | ||
| Although the `enable-webhook` flag default is `false`, the default ECK installation manifests and Helm chart set it to `true`. |
There was a problem hiding this comment.
can we remove "default" later in this sentence? we might rephrase to say "if you're editing x y z / installed using x y z methods, the setting is already present and set to true"
I think a think that makes this confusing is we call this manual configuration but likely it's being applied in a layer over one of these defaults. we also say "If you installed ECK without the webhook" but what is the context that makes this possible?
consider putting this default mismatch info directly in the description rather than as a note below the table
2 participants
Summary
Closes #6160
Clarifies a bit better the default value of
falseof enable-webhook at code level in ECK, while at the same time our default installation enables it by default.