Skip to content

fix(nodeenv): replace leftover debug print with logger.debug #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekalinin merged 1 commit into from
Aug 13, 2026
+9 −1
Merged

fix(nodeenv): replace leftover debug print with logger.debug #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nodeenv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,9 @@ def _get_last_node_version(lts=False):
"""
Return last node.js version matching the filter
"""
print({"x86": is_x86_64_musl(), "risc": is_riscv64(), "lts": lts})
logger.debug(
' * Host platform: x86_64-musl=%s, riscv64=%s, lts=%s',
is_x86_64_musl(), is_riscv64(), lts)

def version_filter(v):
if lts and not v['lts']:
Expand Down
6 changes: 6 additions & 0 deletions tests/nodeenv_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,12 @@ def test_get_lts_node_version_riscv64():
assert nodeenv.get_last_lts_node_version() == '12.13.1'


@pytest.mark.usefixtures('mock_index_json', 'mock_host_platform')
def test_get_last_node_version_writes_nothing_to_stdout(capsys):
nodeenv.get_last_stable_node_version()
assert capsys.readouterr().out == ''


def test__download_node_file():
with mock.patch.object(nodeenv, 'urlopen') as m_urlopen:
m_urlopen.side_effect = IncompleteRead("dummy")
Expand Down
Loading