bitcoin-wallet: Consider unconfirmed parent fees during PSBT fee estimation

[xn1xn1]

Closes #456.

[binarybaron]

thank you for the contribution!

please disclose the extend to which this was LLM generated.

[xn1xn1]

thank you for the contribution!

please disclose the extend to which this was LLM generated.

Hi there. I did use Claude (and gpt5) with adaptive thinking to generate some barebones pseudocode which I used to work on further, as I'm not familiar with this code base. I rechecked and reviewed the output multiple times though. Let me know if there are any issues. If this repo is strictly no AI, then feel free to close this pull request.

[xn1xn1]

Can squash once you review the new commit.

[binarybaron]

Have you tested this manually ?

[xn1xn1]

Have you tested this manually ?

I did before making some minor change, looks like I misplaced a semicolon. I did now, sorry. 😓

[binarybaron]

@Einliterflasche Review would be good here.

[binarybaron]

bugbot run

[Einliterflasche]

We need a testcase for this. In the regtest environment, broadcast a tx with low fee and then check if the child tx has increased the fee accordingly.

[xn1xn1]

We need a testcase for this. In the regtest environment, broadcast a tx with low fee and then check if the child tx has increased the fee accordingly.

And where should that testcase be?

[Einliterflasche]

The bitcoin test harness is in swap/tests/harness atm. For now you can just add another test case in swap/tests. You don't need the setup_harness function, I think, as we don't need an alice / bob instance to test a Bitcoin transaction. But you can use it if it's easier. At some point we should move the Bitocin harness to it's own crate

[xn1xn1]

@Einliterflasche Can you have a look at the test?

[Einliterflasche]

I just remembered that we have a test directory exclusively for the bitcoin wallet, the tests will fit there better. See #846.

[xn1xn1]

I just remembered that we have a test directory exclusively for the bitcoin wallet, the tests will fit there better. See #846.

Yes, thanks for merging. I didn't bring that up before because I thought it wasn't ready.

[xn1xn1]

@Einliterflasche Mind having a quick look at the newest commit ?

[xn1xn1]

@Einliterflasche Hey, would you mind looking?