Skip to content

Electron style - MacOs#1110

Merged
4pmtong merged 2 commits intomainfrom
electron-style
Mar 13, 2026
Merged

Electron style - MacOs#1110
4pmtong merged 2 commits intomainfrom
electron-style

Conversation

@Douglasymlai
Copy link
Copy Markdown
Contributor

@Douglasymlai Douglasymlai commented Jan 30, 2026

Related Issue

Closes #

Description

Testing Evidence (REQUIRED)

Screenshot 2026-03-11 at 11 35 30 Screenshot 2026-03-11 at 11 35 40
  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

@Douglasymlai Douglasymlai marked this pull request as ready for review February 4, 2026 11:40
@Douglasymlai Douglasymlai added this to the Sprint 13 milestone Feb 4, 2026
@Douglasymlai Douglasymlai requested a review from 4pmtong February 4, 2026 11:49
@4pmtong
Copy link
Copy Markdown
Collaborator

4pmtong commented Mar 10, 2026

Hi @Douglasymlai Could you help resolve the conflicts?

- Add native macOS vibrancy (HUDWindow material), rounded corners, and
  transparent titlebar using koffi to call Objective-C runtime directly
- Replace Electron built-in vibrancy with NSVisualEffectView for better
  control over visual effects
- Use fully transparent background on macOS (#00000000) to let native
  vibrancy show through
- Add backdrop-blur-md and rounded-xl to select dropdowns for glass effect
- Update surface-primary to off-white-50 for more transparency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Douglasymlai Douglasymlai modified the milestones: Sprint 13, Sprint 18 Mar 11, 2026
@Douglasymlai Douglasymlai self-assigned this Mar 11, 2026
Copy link
Copy Markdown
Collaborator

@4pmtong 4pmtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll test it on windows later, if there is no issue, then we can merge it.

@4pmtong 4pmtong self-requested a review March 13, 2026 11:39
@4pmtong 4pmtong merged commit c593669 into main Mar 13, 2026
8 checks passed
4pmtong added a commit that referenced this pull request Mar 23, 2026
4pmtong added a commit that referenced this pull request Mar 23, 2026
Co-authored-by: Douglas <douglas.ym.lai@gmail.com>
dev-miro26 pushed a commit to dev-miro26/eigent that referenced this pull request Mar 24, 2026
Co-authored-by: Douglas <douglas.ym.lai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants