This repository was archived by the owner on Jun 12, 2018. It is now read-only.
removing explicit reference to std::regex#98
Open
aaalgo wants to merge 2 commits intoeidheim:masterfrom
Open
Conversation
Fix REGEX_NS with old g++
Owner
|
Thank you, though I need the case_insensitive_equals and case_insensitive_hash to be non-templated classes in order to be able to move headers to for instance Simple-WebSocket-Server without performing copy on a connection upgrade. Regarding the REGEX_NS, I added 19627bb (with you as author). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compile failed on old compilers due to explicit reference to std::regex.
My fork also has a change to move the hash function out of the templated class. If this is not desirable, please just fix REGEX_NS and disregard this PR.