feat: use concretization cache - #338
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to speed up Spack environment concretization by enabling Spack’s concretization cache and persisting it across Docker build layers via a BuildKit cache mount.
Changes:
- Enable Spack
concretization_cacheinspack-environment/concretizer.yaml. - Add BuildKit cache mounts intended to persist
/root/.spack/cache/concretizationacross builds for both default and custom concretization stages.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spack-environment/concretizer.yaml | Enables Spack concretization cache in the shared concretizer configuration. |
| containers/eic/Dockerfile | Adds BuildKit cache mount for Spack concretization cache during spack concretize steps. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
concretization-cache
branch
from
July 29, 2026 03:35
aeb2dfc to
c7697ff
Compare
Contributor
Author
|
This is essentially the spack v1.2.2 default and only makes sure we persist the concretization caching location. |
wdconinc
moved this to Needs Review
in ePIC Review Board (auto-populated; changes will be discarded)
veprbl
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR enables the new concretization cache. This may speed up concretization when there are no changes. (This may not add a lot on top of our layer caching strategy.)
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply