feat: impose image size limit on cuda containers - #337
Open
wdconinc wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds compressed image size caps for the CUDA-based EIC container images in GitLab CI to catch size regressions early during builds.
Changes:
- Introduce
SIZE_LIMIT_EIC_CUDA_GIBandSIZE_LIMIT_EIC_DEV_CUDA_GIBCI variables to enable the existing image-size check foreic_cudaandeic_dev_cuda.
wdconinc
force-pushed
the
wdconinc-patch-3
branch
from
July 31, 2026 19:43
f7cd9e3 to
48217a6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.gitlab-ci.yml:40
- The size-limit guidance comment still says to update limits "here and in .github/workflows/build-push.yml env", but this file now contains CUDA-specific SIZE_LIMIT_* entries that are not (and per prior discussion, need not be) mirrored in GitHub Actions. This is misleading for future updates—please clarify that only the shared images' limits are updated in both places, while CUDA image limits are GitLab-only.
## in .github/workflows/build-push.yml env.
SIZE_LIMIT_DEBIAN_STABLE_BASE_GIB: "0.9"
SIZE_LIMIT_EIC_CI_GIB: "3.1"
SIZE_LIMIT_EIC_XL_GIB: "4.6"
SIZE_LIMIT_EIC_CUDA_GIB: "8.1"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR imposes an upper limit on the image size for eic_cuda and eic_dev_cuda.
Needs:
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply