feat(vue): add mode: "optional" overload for queries with Option input#748
Merged
Conversation
Agent-Logs-Url: https://github.com/effect-app/libs/sessions/a27dfe5f-fbbb-4bf0-955f-bf881a106181 Co-authored-by: patroza <42661+patroza@users.noreply.github.com>
Agent-Logs-Url: https://github.com/effect-app/libs/sessions/a27dfe5f-fbbb-4bf0-955f-bf881a106181 Co-authored-by: patroza <42661+patroza@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
patroza
May 11, 2026 15:30
View session
Member
|
@copilot Make available for the query helpers on api clients |
…query helpers Agent-Logs-Url: https://github.com/effect-app/libs/sessions/6c63899e-f382-4d80-99bf-9cce72205cdf Co-authored-by: patroza <42661+patroza@users.noreply.github.com>
Contributor
Author
Done in ec01f61 — added the const selectedId = computed(() => someRef.value ? Option.some(someRef.value) : Option.none())
const [result, data] = client.getItemQuery(selectedId, { mode: "optional" }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries had no ergonomic way to conditionally enable/disable based on an optional input value — callers had to manually thread
enabledand unwrap the value themselves.Changes
mode: "optional"overload onuseQuery_anduseQuery—argmust be aWatchSource<Option<I>>(thunk, ref, or computed);enabledis excluded from optionsuseQuerytype, so it works directly viaclient.X.query(...)helpersenabled— derivescomputed(() => Option.isSome(...))and passes it to tanstack; query is disabled whenNone, enabled whenSomeOption.getOrUndefinedused as the query input value; safe because tanstack only callsqueryFnwhenenabledistrueExample