Skip to content

Remove automatic namespace invalidation for commands#726

Open
Copilot wants to merge 6 commits intomainfrom
copilot/remove-automatic-namespace-invalidation
Open

Remove automatic namespace invalidation for commands#726
Copilot wants to merge 6 commits intomainfrom
copilot/remove-automatic-namespace-invalidation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 3, 2026

  • Remove default namespace-based invalidation from getClientInvalidationTargets in mutate.ts
  • Update JSDoc for queryInvalidation option
  • Update wiki documentation with all four invalidation configuration options
  • Add changeset
  • Merge latest main (first round)
  • Merge latest main (second round — handlers-always-functions refactor)
  • Merge latest main (third round — lodash/routing/toast updates)
  • Run pnpm lint-fix — no issues
  • Run pnpm check — passes cleanly

@patroza
Copy link
Copy Markdown
Member

patroza commented May 3, 2026

@copilot improve the example with direct command configuration with invalidation configuration

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 3, 2026

@copilot improve the example with direct command configuration with invalidation configuration

Updated in 806126f. The wiki now documents all four invalidation options with concrete examples:

  1. Request-level (invalidatesQueries on the Command class — preferred, co-located with schema)
  2. clientFor factory-level (second arg to clientFor, applies per-command at client-construction time)
  3. Per-call override (queryInvalidation option at the call site)
  4. Server-driven (via InvalidationKeysFromServer)

Copilot AI requested a review from patroza May 3, 2026 16:33
Copilot finished work on behalf of patroza May 3, 2026 16:33
@patroza
Copy link
Copy Markdown
Member

patroza commented May 4, 2026

@copilot update latest main, check / lint-fix

…tic-namespace-invalidation

Co-authored-by: patroza <42661+patroza@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 4, 2026

@copilot update latest main, check / lint-fix

Done in 0e33acf. Merged latest main, pnpm lint-fix and pnpm check both pass with no issues.

…tic-namespace-invalidation

Co-authored-by: patroza <42661+patroza@users.noreply.github.com>
Copilot finished work on behalf of patroza May 4, 2026 17:37
@patroza
Copy link
Copy Markdown
Member

patroza commented May 4, 2026

@copilot update from latest main and fix everything

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 4, 2026

@copilot update from latest main and fix everything

Branch is already at latest main (5724802). pnpm lint-fix and pnpm check both pass cleanly — no issues to fix.

Copilot finished work on behalf of patroza May 4, 2026 18:45
@patroza patroza marked this pull request as ready for review May 6, 2026 18:34
…tic-namespace-invalidation

Co-authored-by: patroza <42661+patroza@users.noreply.github.com>
Copilot finished work on behalf of patroza May 6, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants