Skip to content

chore: BOMS-39 rename arbi-bom to orbi-bom #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgulati-apphelix merged 2 commits into from
Oct 17, 2025
+13 −0
Merged

chore: BOMS-39 rename arbi-bom to orbi-bom #357

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5128eef
chore: BOMS-39 rename arbi-bom to orbi-bom
vgulati-apphelix Oct 14, 2025
8e190c0
chore: BOMS-39 rename arbi-bom to orbi-bom
vgulati-apphelix Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/upgrade-python-requirements.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,16 @@ jobs:
to: orbi-bom-upgrade-prs@2u-internal.jsmalerts.atlassian.net
from: github-actions <github-actions@edx.org>
body: Upgrade python requirements workflow in ${{github.repository}} failed! For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

- name: Send success notification
if: ${{ success() }}
uses: dawidd6/action-send-mail@v3
with:
server_address: email-smtp.us-east-1.amazonaws.com
server_port: 465
username: ${{secrets.edx_smtp_username}}
password: ${{secrets.edx_smtp_password}}
Copy link
Copy Markdown

@robrap robrap Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use consistent CAPS with the failure code?

Copy link
Copy Markdown

@robrap robrap Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The other PR has all caps for some secrets, but not these, and maybe they should all move to ALL-CAPS?

Copy link
Copy Markdown
Member Author

@vgulati-apphelix vgulati-apphelix Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robrap suggestion implemented.

subject: Upgrade python requirements workflow executed successfully in ${{github.repository}}
to: 'orbi-bom-upgrade-prs@2u-internal.jsmalerts.atlassian.net'
from: github-actions <github-actions@edx.org>
body: Upgrade python requirements workflow executed in ${{ github.repository }}. For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
Copy link
Copy Markdown

@robrap robrap Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this was probably copy/pasted from elsewhere, but thought we could make the status more clear in the body as well.

Suggested change
body: Upgrade python requirements workflow executed in ${{ github.repository }}. For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
body: Upgrade python requirements workflow successfully executed in ${{ github.repository }}. For details see "github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"

Copy link
Copy Markdown
Member Author

@vgulati-apphelix vgulati-apphelix Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robrap suggestion implemented.

Loading