feat: improve internationalization (i18n) workflows, user interface messages, and profile field handling#6
Merged
Conversation
…endedProfileFields component
…endedProfileFields component
…ling in profile saving
- Implemented language preference detection in ExtendedProfileFields component using `getLocale` from `@edx/frontend-platform/i18n`. - Added a reload mechanism to refresh the page when the language preference changes. - Introduced new message for adding field values in messages.js. - Updated index.js to export messages for internationalization. - Created a new i18n module to manage localization. - Added `i18n_extract` script to package.json for extracting translation strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements related to internationalization (i18n) workflows, user interface messages, and profile field handling. The most significant changes add new Makefile targets and scripts to support translation extraction and validation, update UI text to use i18n messages, and improve handling of language preference changes.
Internationalization workflow improvements:
extract_translations,i18n.extract,i18n.concat, and translation change detection. These streamline the process of managing translations and ensure consistency with CI requirements. [1] [2]i18n_extractnpm script to run message extraction usingfedx-scripts formatjs extract.src/i18n/index.jsand updated the package export to includemessagesfor i18n support. [1] [2]User interface and i18n message updates:
BaseField.jsxto use a translatable message with the field label as a parameter, and added the corresponding message definition inmessages.jsx. [1] [2]Profile field and language preference handling:
AccountFieldsto handle errors gracefully and reset the form edition state after save attempts. [1] [2]ExtendedProfileFieldsto reload the page when the user's language preference changes, ensuring the UI updates to the new language. [1] [2]