fix(plugins.js) : makes the config parameter 'withHeadings' works when data is empty

[loic-bellinger]

Noticed that the config parameter withHeadings was not properly working.

More precisely:

table: {
  class: Table,
  inlineToolbar: true,
  config: {
    withHeadings: true
  }
}

was not creating an empty table with headings.

So I made a fix. Tried to change as little code as possible (but I believe getConfig should be optimized further)

This PR #126 also tackles the issue

[neSpecc]

Suggested change

	if (data && configName in data) return data[configName]
	if (data && configName in data) {
	return data[configName]
	}

[loic-bellinger]

I accepted this change (maybe adding a prettier to the project could avoid this kind of formatting stuffs)

[neSpecc]

it will always return false event when there is no value in the config. I think it is not what is expected here. Why default value have been removed?

[loic-bellinger]

Originally, getConfig() was called with defaultValue = false, as you can see here: this.getConfig('withHeadings', false, data)

  getConfig(configName, defaultValue = undefined, savedData = undefined) {
    const data = this.data || savedData;

    if (data) {
      return data[configName] ? data[configName] : defaultValue;
    }

    return this.config && this.config[configName] ? this.config[configName] : defaultValue;
  }

So the result remains the same: false is returned when none of the conditions are met (so technically there is still a default value, it has not been removed).

To provide more context:

I don't really understand the point of having a defaultValue parameter defaulting to undefined (notably because we'd like getConfig() to return a clear value for withHeadings - which should be a boolean according to the documentation) .

And since:

• getConfig() is not used elsewhere
• With the update I made to getConfig a default value is needed only once (versus 2 before)

I just get rid of defaultValue and made getConfig directly return false if none of the conditions are met.

[loic-bellinger]

@neSpecc Any feedback on this issue?

[shcshcshc]

To achieve fixing config, I suggest not using this.data because getConfig is being used for making this.data.
and it works in my case.

Suggested change

	const data = this.data || savedData;
	const data = savedData;