Harden avatar selection and loading for posecode#124 - #1
Draft
a-baran-orhan wants to merge 1 commit into
Draft
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for posecode-dev/posecode#124.
The original PR branch does not allow maintainer edits, so this draft targets
edicate/posecode:main. Merging it into that branch will update posecode-dev#124 while keeping @edib as the original PR author.What this fixes:
rig humanoidas skeleton topology and adds a separate optionalavatar avatar1|avatar2|avatar3appearance selector;characterUrlbehavior andcharacter="off"embed behavior;Validation:
npm test: 47 files, 463 tests passednpm run typechecknpm run buildnpm run build:packagesnpm run check:packagesnpm run eval: 1620/1620 checks across 77 movementsStill required before posecode-dev#124 is merged: confirm the source/license provenance for avatar2 and avatar3 and add the appropriate third-party notice. The GLB metadata does not contain enough information to establish this safely.