refactor(common): rename execution context modules and types#1843
Open
refactor(common): rename execution context modules and types#1843
Conversation
Align module and type names to remove legacy `planning/query` terminology in favor of clearer `plan/exec` naming. - Rename `context::planning` → `context::plan`, `context::query` → `context::exec` - Rename `PlanningTable` → `PlanTable`, `QueryEnv` → `ExecEnv` - Rename `PlanSqlError` → `SqlError` in both plan and exec contexts to eliminate stutter - Rename `PlanningPlanSql` error variant → `PlanSql` in flight handler - Update all downstream imports and type aliases across workspace Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align module and type names to remove legacy
planning/queryterminology in favor of clearerplan/execnaming.context::planning→context::plan,context::query→context::execPlanningTable→PlanTable,QueryEnv→ExecEnvPlanSqlError→SqlErrorin both plan and exec contexts to eliminate stutterPlanningPlanSqlerror variant →PlanSqlin flight handlerNote
Medium Risk
Broad rename/refactor across execution and planning call paths; behavior should be unchanged, but the large surface-area API rename risks missed references or mismatched error handling at integration boundaries.
Overview
Renames the query engine’s core abstractions to clearer plan vs exec terminology:
context::planning→context::plan(PlanningContext→PlanContext) andcontext::query→context::exec(QueryContext→ExecContext), along with associated errors (PlanSqlError→SqlError) and docs.Renames the runtime environment
QueryEnv→ExecEnv(including exports anddefault_session_config) and the planning-only table providerPlanningTable→PlanTable, then updates all downstream call sites (Flight server, admin API schema/manifest validation, derived dataset dumping, streaming query execution, and tests) to use the new modules/types and error variants.Written by Cursor Bugbot for commit 8f9ea14. This will update automatically on new commits. Configure here.