refactor(ampd): standardize env var names with AMP_prefix#1702
Merged
Conversation
Contributor
Author
|
Not sure whether the deprecation notice for this should be in the How long should we keep this in here? |
LNSD
reviewed
Feb 5, 2026
LNSD
reviewed
Feb 5, 2026
Contributor
|
@mitchhs12 I am taking over this PR |
LNSD
force-pushed
the
standardize-ampd-env-vars
branch
from
d2b63ee to
8590030
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
LNSD
force-pushed
the
standardize-ampd-env-vars
branch
from
8590030 to
00784ae
Compare
LNSD
force-pushed
the
standardize-ampd-env-vars
branch
from
00784ae to
e21086f
Compare
shiyasmohd
approved these changes
Feb 23, 2026
Contributor
shiyasmohd
left a comment
shiyasmohd
left a comment
There was a problem hiding this comment.
LGTM ✅
Minor nits added in comments.
LNSD
force-pushed
the
standardize-ampd-env-vars
branch
from
e21086f to
f03c703
Compare
Support deprecated env var names (FLIGHT_SERVER, JSONL_SERVER, ADMIN_SERVER) with runtime deprecation warnings to stderr. Signed-off-by: Lorenzo Delgado <lorenzo@edgeandnode.com>
LNSD
force-pushed
the
standardize-ampd-env-vars
branch
from
f03c703 to
ed64d9b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize environment variable names under the AMP_ namespace and rewrite subcommand help text with precise behavioral descriptions.
FLIGHT_SERVER,JSONL_SERVER,ADMIN_SERVERtoAMP_FLIGHT_SERVER,AMP_JSONL_SERVER,AMP_ADMIN_SERVERin solo/server subcommandsGM_*env var bindings fromampctlgenerate (CLI-only flags)Note
Medium Risk
Changes CLI configuration surface and environment-variable compatibility, which can break existing deployments/scripts despite added deprecation fallbacks.
Overview
Standardizes CLI environment variable bindings to the
AMP_namespace and clarifiesampdsubcommand semantics.ampdnow usesAMP_FLIGHT_SERVER,AMP_JSONL_SERVER, andAMP_ADMIN_SERVERfor endpoint toggles (with runtime backward-compat support for the oldFLIGHT_SERVER/JSONL_SERVER/ADMIN_SERVERnames), and updates help text to document ports and “enable-only-flagged-endpoints” behavior.ampctl manifest generateremoves allGM_*env var bindings, making its inputs CLI-flag-only.Docs are updated to reflect the new env var names/behavior, add configuration reference tables, and introduce/mark feature pages as stable (including a new
app-ampd-migratedoc).Written by Cursor Bugbot for commit ed64d9b. This will update automatically on new commits. Configure here.