feat(wrap): fallback proc scan for first_child_pid_of#92
Draft
noeljackson wants to merge 1 commit intoedera-dev:mainfrom
Draft
feat(wrap): fallback proc scan for first_child_pid_of#92noeljackson wants to merge 1 commit intoedera-dev:mainfrom
noeljackson wants to merge 1 commit intoedera-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a fallback /proc scan to
first_child_pid_of()for kernels withoutCONFIG_PROC_CHILDREN=y.Problem
first_child_pid_of()reads/proc/<pid>/task/<pid>/childrento find the supervised child process. This file only exists when the kernel is built withCONFIG_PROC_CHILDREN=y, which is not always the case (e.g., some minimal or custom kernel configs for Xen PV guests). When the file is missing,attachoperations fail entirely.Solution
/proc/<pid>/task/<pid>/children)./procfor numeric directories and checking each process's/proc/<pid>/statusfor aPPid:line matching the parent.