fix(unshare): close pidfd after setns#90
Draft
noeljackson wants to merge 1 commit intoedera-dev:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a file descriptor leak in
setns(): the pidfd obtained frompidfd_open()was never closed after being passed tosetns(2).Each call to
setns()leaked one file descriptor. In long-running processes that attach to containers repeatedly (e.g. exec into a container), this would eventually exhaust the fd limit.The fix captures the setns result, unconditionally closes the pidfd via
libc::close(), then returns the result. The close happens regardless of whether setns succeeded or failed.