Always update semver tags consistently + support building/tagging/publishing non-main kernel builds#152
Open
Always update semver tags consistently + support building/tagging/publishing non-main kernel builds#152
semver tags consistently + support building/tagging/publishing non-main kernel builds#152Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149
Now, if you pass any semver to a build with
publish=true, we will always update all semver tags in the registry:Ex (before):
Ex (now):
Before, this meant that even if we built and published off of
main, the6and6.18refs would not get updated, only the6.18.16ref would get updated. You can work around this by passing tags in the build arg, if you remember the complete set and if you pass them, but that's not fail-closed since we let you partially update a public ref, and it's too easy to footgun and end up with inconsistent semver refs in the public registry this way, and we really have no reason not to keep all semver tags forcibly in sync with all publishedmainbuilds, regardless....with the exception of wanting to build one-off/oneshot/test kernels that do not update any official refs. So this also supports doing that via the following:
If you trigger the GH Action with
publish=trueagainstmain, you now get "official" tags above:If you trigger the GH Acton with
publish=trueagainst any other branch, you now get the Github ref branchname of that branch appended to all published tag names:So in this way we can create branches and publish images to unique tags if we want, but all
mainbuilds always update all semver tags, so we can never collide.