Skip to content

Comments

METK-144 Replace & Remove GribHandle#153

Draft
pgeier wants to merge 2 commits intodevelopfrom
feature/METK-144-ReplaceGribHandle
Draft

METK-144 Replace & Remove GribHandle#153
pgeier wants to merge 2 commits intodevelopfrom
feature/METK-144-ReplaceGribHandle

Conversation

@pgeier
Copy link
Contributor

@pgeier pgeier commented Feb 2, 2026

Description

This PR removes the usage of metkit/GribHandle everywhere possible in favor of new CodesHandle.
Fully removal will change once subsequent PRs using old CodesHandle have been merged.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@pgeier pgeier force-pushed the feature/METK-144-ReplaceGribHandle branch 3 times, most recently from e8e01cc to c25e744 Compare February 2, 2026 14:21
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.10%. Comparing base (7094899) to head (cad1926).

Files with missing lines Patch % Lines
src/metkit/pointdb/PointIndex.cc 0.00% 16 Missing ⚠️
src/metkit/pointdb/GribFieldInfo.cc 0.00% 12 Missing ⚠️
src/metkit/pointdb/GribHandleDataSource.cc 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #153      +/-   ##
===========================================
+ Coverage    59.10%   60.10%   +1.00%     
===========================================
  Files          309      302       -7     
  Lines        11671    11376     -295     
  Branches      1022     1011      -11     
===========================================
- Hits          6898     6838      -60     
+ Misses        4773     4538     -235     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pgeier pgeier force-pushed the feature/METK-144-ReplaceGribHandle branch from c25e744 to 570e041 Compare February 12, 2026 15:25
@pgeier pgeier force-pushed the feature/METK-144-ReplaceGribHandle branch from 570e041 to 06e04dd Compare February 23, 2026 14:43
@pgeier pgeier force-pushed the feature/METK-144-ReplaceGribHandle branch from 06e04dd to 39c8aab Compare February 24, 2026 13:47
@pgeier pgeier force-pushed the feature/METK-144-ReplaceGribHandle branch from 39c8aab to cad1926 Compare February 24, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants