Skip to content

Comments

Correct Dependencies path#286

Merged
marcosbento merged 3 commits intodevelopfrom
task/enable_submodule_build
Feb 23, 2026
Merged

Correct Dependencies path#286
marcosbento merged 3 commits intodevelopfrom
task/enable_submodule_build

Conversation

@marcosbento
Copy link
Collaborator

@marcosbento marcosbento commented Feb 20, 2026

Description

The following changes allow adding ecflow as a submodule/subproject of an umbrela CMake project:

  • Correct Dependencies path
  • Correct location of ecFlow executables, used for testing

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-286

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (5ffb39a) to head (86865eb).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #286      +/-   ##
===========================================
+ Coverage    49.34%   49.38%   +0.04%     
===========================================
  Files         1234     1234              
  Lines        97921    97916       -5     
  Branches     14880    14881       +1     
===========================================
+ Hits         48316    48356      +40     
+ Misses       49605    49560      -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento marcosbento force-pushed the task/enable_submodule_build branch from a5557e5 to 7602a7f Compare February 20, 2026 15:32
This effectively sets CMAKE_ECFLOW_BUILD_DIR to CMAKE_BINARY_DIR,
instead of enforcing the location to be inside the project itself.
@marcosbento marcosbento force-pushed the task/enable_submodule_build branch from 7602a7f to 86865eb Compare February 20, 2026 15:43
@marcosbento marcosbento merged commit 86865eb into develop Feb 23, 2026
157 checks passed
@marcosbento marcosbento deleted the task/enable_submodule_build branch February 23, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants