Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #286 +/- ##
===========================================
+ Coverage 49.34% 49.38% +0.04%
===========================================
Files 1234 1234
Lines 97921 97916 -5
Branches 14880 14881 +1
===========================================
+ Hits 48316 48356 +40
+ Misses 49605 49560 -45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a5557e5 to
7602a7f
Compare
This effectively sets CMAKE_ECFLOW_BUILD_DIR to CMAKE_BINARY_DIR, instead of enforcing the location to be inside the project itself.
7602a7f to
86865eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The following changes allow adding ecflow as a submodule/subproject of an umbrela CMake project:
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-286