fix checkpoint loading for unsharded target encoder - #2729
Draft
Jubeku wants to merge 1 commit into
Draft
Conversation
clessig
reviewed
Aug 4, 2026
|
|
||
| is_model_sharded = cf.with_ddp and cf.with_fsdp | ||
| # Determine shardedness from the model instance itself, NOT from the global config flags: | ||
| is_model_sharded = any(type(p) is torch.distributed.tensor.DTensor for p in model.parameters()) |
Collaborator
There was a problem hiding this comment.
It would be better to then have it as an argument to load_model()
github-actions
Bot
added
the
model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue Number
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60