Skip to content

Comments

Fix inconsistent config#1885

Open
clessig wants to merge 1 commit intodevelopfrom
clessig/develop/fix_trainer_cfgs_1884
Open

Fix inconsistent config#1885
clessig wants to merge 1 commit intodevelopfrom
clessig/develop/fix_trainer_cfgs_1884

Conversation

@clessig
Copy link
Collaborator

@clessig clessig commented Feb 19, 2026

Description

Fix inconsistent configs in train and inference

Issue Number

Closes #1884

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@clessig
Copy link
Collaborator Author

clessig commented Feb 19, 2026

Needs to be merged after frozen teacher

@github-actions github-actions bot added bug Something isn't working model Related to model training or definition (not generic infra) labels Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working model Related to model training or definition (not generic infra)

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Config init is inconsitent between training and inference

1 participant