Sophiex/dev/pretrained frozen teacher#1824
Closed
sophie-xhonneux wants to merge 42 commits intodevelopfrom
Closed
Conversation
The fix now: 1. FrozenTeacher inspects the teacher model's actual latent_heads attribute to determine what postprocessing is needed 2. Sets up JEPA/DINO/iBOT postprocessing based on what heads exist (using identity transform for all, with warnings for DINO/iBOT since full centering isn't supported for frozen teachers) 3. Tests updated to use models with latent_heads attributes
Summary of Changes
Key insight from your feedback: The frozen teacher may have been pre-trained with any method
(forecasting, MAE, etc.) and doesn't need to have SSL latent heads. We should:
1. Use the student's training config to know which SSL losses are needed
2. Add identity heads (LatentPredictionHeadIdentity) to the teacher if they don't exist
3. Use identity postprocessing (JEPATargetProcessing) for all SSL losses
Changes Made
src/weathergen/train/target_and_aux_ssl_teacher.py:
- Added import for LatentPredictionHeadIdentity
- Rewrote FrozenTeacher.__init__ to:
- Accept training_cfg (the student's config) to determine required SSL heads
- Call _get_required_ssl_heads() to extract loss names from config
- Call _ensure_identity_heads() to add missing heads to the teacher model
- Set up identity postprocessing for all SSL losses
- Added _get_required_ssl_heads(): extracts SSL loss names from training config, defaults to {"JEPA"} if
none found
- Added _ensure_identity_heads(): adds LatentPredictionHeadIdentity for any missing heads
- Updated from_pretrained() to pass cf.training_config to constructor
tests/test_encoder_teacher.py:
- Added model_without_latent_heads fixture (simulates a forecasting-only teacher)
- Added 5 new tests:
- test_frozen_teacher_adds_identity_heads_when_missing
- test_frozen_teacher_uses_training_cfg_for_heads
- test_frozen_teacher_defaults_to_jepa_without_config
- test_frozen_teacher_preserves_existing_heads
- test_frozen_teacher_all_postprocessing_is_identity
clessig
reviewed
Feb 11, 2026
Collaborator
clessig
left a comment
clessig
left a comment
There was a problem hiding this comment.
Some high level comments. The PR should be split up into the three independent contributions that are in it currently
| from weathergen.model.norms import AdaLayerNorm, RMSNorm | ||
|
|
||
|
|
||
| class LayerScale(nn.Module): |
Collaborator
There was a problem hiding this comment.
Can we put this into a separate PR--it's not related to the frozen teacher
| return x * self.gamma | ||
|
|
||
|
|
||
| class StochasticDepth(nn.Module): |
Collaborator
There was a problem hiding this comment.
Can we put this into a separate PR--it's not related to the frozen teacher
|
|
||
| return self.lr | ||
|
|
||
| def _set_param_group_lrs(self, base_lr: float): |
Collaborator
There was a problem hiding this comment.
Can we put this into a separate PR--it's not related to the frozen teacher
| lr_multiplier = g.get("lr_multiplier", 1.0) | ||
| g["lr"] = base_lr * lr_multiplier | ||
|
|
||
| def _apply_lr_multipliers(self): |
Collaborator
There was a problem hiding this comment.
Can we put this into a separate PR--it's not related to the frozen teacher
|
|
||
| # Initialize collapse monitor for SSL training | ||
| collapse_config = self.training_cfg.get("collapse_monitoring", {}) | ||
| self.collapse_monitor = CollapseMonitor(collapse_config, None) # device set later in run() |
Collaborator
There was a problem hiding this comment.
devices[9] is available here
| self.ema_model.update(self.cf.general.istep * batch_size_total, batch_size_total) | ||
|
|
||
| # Compute collapse monitoring metrics | ||
| if self.collapse_monitor.should_compute(self.cf.general.istep): |
Collaborator
There was a problem hiding this comment.
Move if statement into the function that you call. It's better encapsulation.
| if bidx % self.train_log_freq.metrics == 0: | ||
| self._log(TRAIN) | ||
| # Log collapse metrics | ||
| if self.collapse_monitor.should_log(self.cf.general.istep): |
Collaborator
There was a problem hiding this comment.
Move if statement into the function that you call. It's better encapsulation.
| is_rank_zero = is_root() | ||
|
|
||
| # Handle CompositeOptimizer (Muon+AdamW) separately | ||
| if isinstance(self.optimizer, CompositeOptimizer): |
Collaborator
There was a problem hiding this comment.
If we have this encapsulation, we should also encapsulate the part for native AdamW into a separate function.
| else: | ||
| return {} | ||
|
|
||
| def _get_full_composite_optimizer_state_dict(self, is_rank_zero: bool): |
Collaborator
There was a problem hiding this comment.
This should go to optimizer.py
|
|
||
| self.t_start = time.time() | ||
|
|
||
| def _compute_collapse_metrics(self, preds, targets_and_auxs) -> None: |
Collaborator
There was a problem hiding this comment.
This should not be in trainer.py
Collaborator
There was a problem hiding this comment.
I think it would be best to have this as a separate class and then we could also split up the function.
* implemented * remove eval in interface * lint * incoporate requested changes * fix imports * Fix corner case in inference where data window is empty * Fix missing handling of missing load_chkpt argument in config --------- Co-authored-by: moritzhauschulz <moritz.hauschulz@gmail.com>
…but also as entrypoints. (#1778) * Clean up docstrings, separate cli parsing from running. * remove unused argument stream_dir * separate parser instantiation from adding args * add unified parser with subparsers * implement main function in run_train using subparsers. * update integration tests * remove redundant methods *_from_args (previously used by integration tests) * Move entrypoints to the top of run_train.py * fix typo in small_multi_stream_test.infer_multi_stream * fix formatting * Organize strings into enum. * fix parser
* Implement best effort backward compatibility. * use new `data_pathes` option to look up training data. * fix integration tests * linting * correct spelling in config.py * correct spelling in multi_stream_data_sampler.py * fix typo "data_path_anmoi" -> "data_path_anemoi" in config.py * Update test_config.py * Add suggested comment.
* Fixed most parts of plot_train. Currently missing: handling of stage_configs when these are derived from an earlier stage. * Removed outdated or unsupported options * Fixed final problems with consolidated training/validation config. Required to move Stage to a more appropriate place * Removed old, unused code
* nse_metric * length --------- Co-authored-by: Jesica Pinyon Rodriguez <jpinyonr@login07.leonardo.local>
github-actions
bot
added
data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal is to train against a frozen pre-trained teacher (e.g. by MAE)
Issue Number
Closes #1815
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60