Skip to content

Comments

[Build] Update to Tycho 5.0.2#3602

Open
HannesWell wants to merge 1 commit intoeclipse-xtext:mainfrom
HannesWell:tycho-5.0.2
Open

[Build] Update to Tycho 5.0.2#3602
HannesWell wants to merge 1 commit intoeclipse-xtext:mainfrom
HannesWell:tycho-5.0.2

Conversation

@HannesWell
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Feb 15, 2026

Test Results

  6 460 files  + 1 608    6 460 suites  +1 608   3h 9m 47s ⏱️ + 53m 21s
 43 235 tests  -      1   42 651 ✅  -      1    584 💤 ±  0  0 ❌ ±0 
170 058 runs  +42 539  167 721 ✅ +41 955  2 337 💤 +584  0 ❌ ±0 

Results for commit 0f0dd8a. ± Comparison against base commit 99a5c22.

This pull request removes 1 test.
org.eclipse.xtend.xtend.archetype.integrationtest.HelloXtendTest ‑ testHelloXtend

♻️ This comment has been updated with latest results.

@cdietrich
Copy link
Contributor

With respect to the wizard and tycho needing 21 to run this is why we in the past also ditched old Java version support
Am not sure
if people who will select Java 17 in the wizard know how to setup tool chains or that they have to when they see the error message

but I currently have no time nor mental capacity to address the big update everything task nor seems to have someone else

@HannesWell
Copy link
Contributor Author

With respect to the wizard and tycho needing 21 to run this is why we in the past also ditched old Java version support

Yes, but since we are late in the release cycle and it was mentioned in #3546 (comment), that Java-17 support is intended until the next release cycle I didn't want to do that for now.
My primary goal is to have Runtime support for Java-25 in the IDE and the xtend-maven-plugin as soon as possible, ideally in the upcoming release.

And you said that Tycho 5.0 would be a prerequisite.

I'm happy to help also with the big tasks in the next cycle, but for now I assume that's out of scope?

Am not sure if people who will select Java 17 in the wizard know how to setup tool chains or that they have to when they see the error message

Yes, I'm currently investigating if the use of a corresponding maven-enforcer rule could at least clarify the situation and make the build fail with a meaningful message in case Java<21 is used to run the build.

@cdietrich
Copy link
Contributor

yes, from my pov all should go into next release.
i dont even really have time to build m3 this week and release next week

@HannesWell
Copy link
Contributor Author

yes, from my pov all should go into next release.

Do you think there is any chance to have at least minimal runtime support for Java-25 in the upcoming release?
E.g. the corresponding compiler constants available so that the xtend-maven-plugin doesn't fail when running with java-25?
I can try to create such a minimal PR.

@cdietrich
Copy link
Contributor

cdietrich commented Feb 16, 2026

i fear that would lead to utterly chaos in wizard etc.
i also have no time to support in any capacity

what happens if user selects java 25 here
grafik
in any of the combinations

@cdietrich
Copy link
Contributor

and ofc we inherit a lot of our runtime behaviour from old jdt here
https://github.com/eclipse-xtext/xtext/blob/main/org.eclipse.xtext.dev-bom/pom.xml
and new jdt might explode code needs 21 as minimum runtime

@cdietrich
Copy link
Contributor

=> how would it help to just edit

the ClassFIleConstants copy (if we still have that somewhere where i cannot find it right now)

@HannesWell
Copy link
Contributor Author

i fear that would lead to utterly chaos in wizard etc.
i also have no time to support in any capacity

Too bad, but I understand. Lets discuss if we can achieve something minimal for Java-25 in

@HannesWell
Copy link
Contributor Author

Am not sure if people who will select Java 17 in the wizard know how to setup tool chains or that they have to when they see the error message

Yes, I'm currently investigating if the use of a corresponding maven-enforcer rule could at least clarify the situation and make the build fail with a meaningful message in case Java<21 is used to run the build.

Using enforcer does not really help, because Tycho must be configuration as an extension and e.g. Tycho's custom packaging-type classes are loaded very early when a Maven build is bootstrapped. And the enforcer rules aren't checked that early. So the build fails with an errors that tells (relatively far down in the stack) that the class file version is not supported by the runtime.
One can understand that, but it's a bit more advanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants