Conversation
47dba44 to
01f9605
Compare
Test Results 6 460 files + 1 608 6 460 suites +1 608 3h 9m 47s ⏱️ + 53m 21s Results for commit 0f0dd8a. ± Comparison against base commit 99a5c22. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
01f9605 to
f51f2c5
Compare
|
With respect to the wizard and tycho needing 21 to run this is why we in the past also ditched old Java version support but I currently have no time nor mental capacity to address the big update everything task nor seems to have someone else |
Yes, but since we are late in the release cycle and it was mentioned in #3546 (comment), that Java-17 support is intended until the next release cycle I didn't want to do that for now. And you said that Tycho 5.0 would be a prerequisite. I'm happy to help also with the big tasks in the next cycle, but for now I assume that's out of scope?
Yes, I'm currently investigating if the use of a corresponding maven-enforcer rule could at least clarify the situation and make the build fail with a meaningful message in case Java<21 is used to run the build. |
|
yes, from my pov all should go into next release. |
Do you think there is any chance to have at least minimal runtime support for Java-25 in the upcoming release? |
|
and ofc we inherit a lot of our runtime behaviour from old jdt here |
|
=> how would it help to just edit the ClassFIleConstants copy (if we still have that somewhere where i cannot find it right now) |
Too bad, but I understand. Lets discuss if we can achieve something minimal for Java-25 in |
Using enforcer does not really help, because Tycho must be configuration as an extension and e.g. Tycho's custom packaging-type classes are loaded very early when a Maven build is bootstrapped. And the enforcer rules aren't checked that early. So the build fails with an errors that tells (relatively far down in the stack) that the class file version is not supported by the runtime. |
f51f2c5 to
0f0dd8a
Compare

Part of