Fix null element handling in array bind parameters - #1692
Open
adityaanikam wants to merge 1 commit into
Open
Conversation
PgParamDesc.prepare() applied the array element type's preEncoder function unconditionally to every array element, including nulls. For NUMERIC[] parameters this causes prepareNumeric() to be invoked on a null element, and the bound query never completes. Skip the preEncoder call for null elements so they are preserved as SQL NULL, matching how non-array parameters already handle null. Closes eclipse-vertx#1690 Signed-off-by: adityaanikam <adityanikam9502@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PgParamDesc.prepare() applied the array element type's preEncoder function unconditionally to every array element, including nulls. For NUMERIC[] parameters this causes prepareNumeric() to be invoked on a null element, and the bound query never completes.
Skip the preEncoder call for null elements so they are preserved as SQL NULL, matching how non-array parameters already handle null.
Closes #1690
Motivation:
Binding a NUMERIC[] parameter containing a null element causes the query to hang indefinitely instead of completing, because PgParamDesc.prepare() calls the NUMERIC preEncoder on every array element without checking for null first. Added a regression test that reproduces this with a real Postgres instance, confirmed via a negative control that it fails with a TimeoutException without the fix, and confirmed the fix makes it pass.
Conformance:
The commit is signed off (git commit -s). Ran mvn -pl vertx-pg-client clean test (NumericTypesExtendedCodecTest: 42/42 passing) and mvn -pl vertx-pg-client spotless:check (clean).