Conversation
Member
vietj
commented
Apr 10, 2026
vietj
commented
- Avoid declaring VertxBootstrapImpl in VertxBootstrap contract
- Let the VertxBootstrap be configured with a list of service providers to use as an alternative to Service Loader.
- Move the discovery of VerticleFactory implementations to the VertxBuilder bootstrap.
… to use as an alternative to Service Loader. Motivation: VertxBootstrap discovers the vertx service provider list using Java's service loader, coupling the configuration of a Vertx instance to the service loader. Advanced users of Vertx should be able to provide their own list of service providers, instead of relying on this behavior.
…lder bootstrap. Motivation: The VerticleManager discovers the list of VerticleFactory in its constructor, forcing the discovery to use Java's ServiceLoader. This should be overridable, to let advanced Vert.x users provide their list of VerticleFactory implementation when boostrapping a Vertx instance. Changes: Move the discovery of VerticleFactory to VertxBuilder. Add a list known of VerticleFactory on the VertxBuilder that is used instead of performing discovery when provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.