mvn: update maven plugin versions and fix build messages#399
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughParent pom.xml receives version bumps for build tooling (Tycho, CBI, RCPTT, Sonar, JaCoCo) and Maven plugins. Feature-source execution is removed from tycho-source-plugin. Documentation and UI module pom.xml files standardize maven-antrun-plugin Ant task XML structure by normalizing echo message placement within target blocks. ChangesBuild Configuration and Dependency Version Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
pom.xml (1)
43-43:⚠️ Potential issue | 🟠 Major | ⚡ Quick winAlign
required-maven-versionwith Tycho 5.0.2’s Maven minimum.
- Tycho 5.0.2’s system requirements list Maven 3.9.9 as the minimum, but
pom.xmlcurrently setsrequired-maven-versionto 3.9.🔧 Proposed fix
- <required-maven-version>3.9</required-maven-version> + <required-maven-version>3.9.9</required-maven-version>
build-api-docsprofile pinsmaven-javadoc-pluginto 3.6.2, while the rest of the build config uses 3.12.0; align these to avoid inconsistent javadoc behavior across profiles.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pom.xml` at line 43, Update the pom.xml to match Tycho 5.0.2’s Maven minimum by changing the required-maven-version value from "3.9" to "3.9.9", and align javadoc plugin versions by updating the maven-javadoc-plugin declaration inside the build-api-docs profile to use the same version used elsewhere in the build (3.12.0) so javadoc behavior is consistent across profiles; modify the XML elements named required-maven-version and the maven-javadoc-plugin entry inside the build-api-docs profile accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@pom.xml`:
- Line 43: Update the pom.xml to match Tycho 5.0.2’s Maven minimum by changing
the required-maven-version value from "3.9" to "3.9.9", and align javadoc plugin
versions by updating the maven-javadoc-plugin declaration inside the
build-api-docs profile to use the same version used elsewhere in the build
(3.12.0) so javadoc behavior is consistent across profiles; modify the XML
elements named required-maven-version and the maven-javadoc-plugin entry inside
the build-api-docs profile accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: dab6a323-c691-45a4-bc02-927971421ad8
📒 Files selected for processing (7)
doc/org.eclipse.tracecompass.doc.dev/pom.xmldoc/org.eclipse.tracecompass.doc.user/pom.xmldoc/org.eclipse.tracecompass.gdbtrace.doc.user/pom.xmldoc/org.eclipse.tracecompass.rcp.doc.user/pom.xmldoc/org.eclipse.tracecompass.tmf.pcap.doc.user/pom.xmlpom.xmltmf/org.eclipse.tracecompass.tmf.ui/pom.xml
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
1 participant
What it does
mvn: update maven plugin versions and fix build messages
mvn: remove feature-source execution as it is now deprecated. From what I understand, this creates a source feature that bundles the code with the updateSite. We need to find another solution.
How to test
Build Trace Compass
Follow-ups
N/A
Review checklist
Summary by CodeRabbit
Release Notes