releng: Add e4.39 and update Staging targets, plugin and feature versions#385
releng: Add e4.39 and update Staging targets, plugin and feature versions#385arfio merged 1 commit intoeclipse-tracecompass:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (125)
✅ Files skipped from review due to trivial changes (115)
🚧 Files skipped from review as they are similar to previous changes (10)
📝 WalkthroughWalkthroughRepository-wide version bump from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target (1)
92-100:⚠️ Potential issue | 🟠 MajorRemove ECF entries from eStaging target to align with e4.39 target.
The PR description states "Remove dependency on Eclipse ECF", and the e4.39 target already has all ECF entries removed. However, the ECF location block (lines 92–100) with six feature units and the repository URL remains in eStaging. These entries should be removed to complete the ECF dependency removal across all target files.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target` around lines 92 - 100, Remove the entire ECF location block from the eStaging target: delete the <location ... type="InstallableUnit"> element that contains the six <unit> entries (org.eclipse.ecf.core.feature.feature.group, org.eclipse.ecf.filetransfer.feature.feature.group, org.eclipse.ecf.filetransfer.httpclient5.feature.feature.group, org.eclipse.ecf.filetransfer.httpclientjava.feature.feature.group, org.eclipse.ecf.core.ssl.feature.feature.group, org.eclipse.ecf.filetransfer.ssl.feature.feature.group) and the <repository location="https://download.eclipse.org/rt/ecf/3.16.5/site.p2/"/> entry so the eStaging target matches the e4.39 target and no longer references ECF.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@releng/org.eclipse.tracecompass.target/tracecompass-e4.39.target`:
- Around line 1-114: Add a new artifact entry for the target file so the e4.39
target is attached to the build: open the module pom.xml containing the
<artifacts> section and add an <artifact> element with
<file>tracecompass-e4.39.target</file>, <type>target</type> and
<classifier>tracecompass-e4.39</classifier>; ensure the new <artifact> sits
inside the existing <artifacts> container and the tag names match exactly so the
build system will publish the target file.
---
Outside diff comments:
In `@releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target`:
- Around line 92-100: Remove the entire ECF location block from the eStaging
target: delete the <location ... type="InstallableUnit"> element that contains
the six <unit> entries (org.eclipse.ecf.core.feature.feature.group,
org.eclipse.ecf.filetransfer.feature.feature.group,
org.eclipse.ecf.filetransfer.httpclient5.feature.feature.group,
org.eclipse.ecf.filetransfer.httpclientjava.feature.feature.group,
org.eclipse.ecf.core.ssl.feature.feature.group,
org.eclipse.ecf.filetransfer.ssl.feature.feature.group) and the <repository
location="https://download.eclipse.org/rt/ecf/3.16.5/site.p2/"/> entry so the
eStaging target matches the e4.39 target and no longer references ECF.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b40d4333-f7a0-4f0c-b599-b67e8251608d
📒 Files selected for processing (125)
analysis/org.eclipse.tracecompass.analysis.counters.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.counters.ui.swtbot.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.graph.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.lami.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.lami.ui.swtbot.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.os.linux.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.os.linux.ui.swtbot.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.os.linux.ui.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.profiling.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.profiling.ui.swtbot.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.timing.core.tests/pom.xmlanalysis/org.eclipse.tracecompass.analysis.timing.ui.swtbot.tests/pom.xmlanalysis/pom.xmlbtf/org.eclipse.tracecompass.btf.core.tests/pom.xmlbtf/org.eclipse.tracecompass.btf/feature.xmlbtf/pom.xmlcommon/org.eclipse.tracecompass.common.core.tests/pom.xmlcommon/pom.xmlctf/org.eclipse.tracecompass.ctf.core.tests/pom.xmlctf/org.eclipse.tracecompass.ctf.parser.tests/pom.xmlctf/org.eclipse.tracecompass.ctf.parser/pom.xmlctf/org.eclipse.tracecompass.ctf/feature.xmlctf/org.eclipse.tracecompass.tmf.ctf.core.tests/pom.xmlctf/org.eclipse.tracecompass.tmf.ctf.ui.swtbot.tests/pom.xmlctf/org.eclipse.tracecompass.tmf.ctf/feature.xmlctf/pom.xmldoc/org.eclipse.tracecompass.analysis.profiling.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.analysis.profiling.doc.user/pom.xmldoc/org.eclipse.tracecompass.doc.dev/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.doc.dev/pom.xmldoc/org.eclipse.tracecompass.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.doc.user/pom.xmldoc/org.eclipse.tracecompass.gdbtrace.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.gdbtrace.doc.user/pom.xmldoc/org.eclipse.tracecompass.rcp.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.rcp.doc.user/pom.xmldoc/org.eclipse.tracecompass.tmf.pcap.doc.user/META-INF/MANIFEST.MFdoc/org.eclipse.tracecompass.tmf.pcap.doc.user/pom.xmldoc/pom.xmlgdbtrace/org.eclipse.tracecompass.gdbtrace.core.tests/pom.xmlgdbtrace/org.eclipse.tracecompass.gdbtrace.ui.tests/pom.xmlgdbtrace/org.eclipse.tracecompass.gdbtrace/feature.xmlgdbtrace/pom.xmljsontrace/org.eclipse.tracecompass.jsontrace.core.tests/pom.xmljsontrace/org.eclipse.tracecompass.jsontrace/feature.xmljsontrace/pom.xmllttng/org.eclipse.tracecompass.lttng2.common.core.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.control.core.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.control.ui.swtbot.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.control.ui.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.control/feature.xmllttng/org.eclipse.tracecompass.lttng2.kernel.core.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.kernel.ui.swtbot.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.kernel/feature.xmllttng/org.eclipse.tracecompass.lttng2.ust.core.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.ust.ui.swtbot.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.ust.ui.tests/pom.xmllttng/org.eclipse.tracecompass.lttng2.ust/feature.xmllttng/pom.xmlpcap/org.eclipse.tracecompass.pcap.core.tests/pom.xmlpcap/org.eclipse.tracecompass.tmf.pcap.core.tests/pom.xmlpcap/org.eclipse.tracecompass.tmf.pcap.ui.swtbot.tests/pom.xmlpcap/org.eclipse.tracecompass.tmf.pcap/feature.xmlpcap/pom.xmlpom.xmlrcp/org.eclipse.tracecompass.rcp.branding.feature/feature.xmlrcp/org.eclipse.tracecompass.rcp.branding.feature/pom.xmlrcp/org.eclipse.tracecompass.rcp.branding/META-INF/MANIFEST.MFrcp/org.eclipse.tracecompass.rcp.branding/about.propertiesrcp/org.eclipse.tracecompass.rcp.branding/plugin.xmlrcp/org.eclipse.tracecompass.rcp.branding/pom.xmlrcp/org.eclipse.tracecompass.rcp.incubator/feature.xmlrcp/org.eclipse.tracecompass.rcp.product/legacy-e4.23-e4.25/tracing.productrcp/org.eclipse.tracecompass.rcp.product/legacy-e4.26-e4.29/tracing.productrcp/org.eclipse.tracecompass.rcp.product/legacy/tracing.productrcp/org.eclipse.tracecompass.rcp.product/pom.xmlrcp/org.eclipse.tracecompass.rcp.product/tracing.productrcp/org.eclipse.tracecompass.rcp.rcptt.tests/pom.xmlrcp/org.eclipse.tracecompass.rcp.ui.tests/pom.xmlrcp/org.eclipse.tracecompass.rcp.ui/META-INF/MANIFEST.MFrcp/org.eclipse.tracecompass.rcp/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.30/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.32/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.33/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.34/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.35/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.36/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy-e4.37/feature.xmlrcp/org.eclipse.tracecompass.rcp/legacy/feature.xmlrcp/org.eclipse.tracecompass.rcp/pom.xmlrcp/pom.xmlreleng/org.eclipse.tracecompass.alltests/pom.xmlreleng/org.eclipse.tracecompass.integration.core.tests/pom.xmlreleng/org.eclipse.tracecompass.integration.swtbot.tests/pom.xmlreleng/org.eclipse.tracecompass.releng-site/pom.xmlreleng/org.eclipse.tracecompass.target/pom.xmlreleng/org.eclipse.tracecompass.target/tracecompass-e4.39.targetreleng/org.eclipse.tracecompass.target/tracecompass-eStaging.targetreleng/org.eclipse.tracecompass.testing/feature.xmlreleng/pom.xmlreleng/scripts/update_parent_pom_versions.pyreleng/scripts/update_root_pom_versions.pystatesystem/org.eclipse.tracecompass.datastore.core.tests/pom.xmlstatesystem/org.eclipse.tracecompass.segmentstore.core.tests/pom.xmlstatesystem/org.eclipse.tracecompass.statesystem.core.tests/pom.xmlstatesystem/pom.xmltmf/org.eclipse.tracecompass.tmf.analysis.xml.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.analysis.xml.ui.swtbot.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.analysis.xml.ui.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.chart.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.chart.ui.swtbot.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.chart.ui.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.cli.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.cli/feature.xmltmf/org.eclipse.tracecompass.tmf.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.filter.parser/pom.xmltmf/org.eclipse.tracecompass.tmf.remote.core.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.remote.ui.swtbot.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.remote.ui.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.remote/feature.xmltmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.ui.tests/pom.xmltmf/org.eclipse.tracecompass.tmf.ui/pom.xmltmf/org.eclipse.tracecompass.tmf/feature.xmltmf/pom.xml
| <?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="tracecompass-e39" sequenceNumber="1"> | ||
| <locations> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <repository location="https://download.eclipse.org/justj/jres/21/updates/release/21.0.10/"/> | ||
| <unit id="org.eclipse.justj.openjdk.hotspot.jre.minimal.stripped.feature.group" version="0.0.0"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.eclipse.cdt.gnu.dsf.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.remote.core" version="0.0.0"/> | ||
| <unit id="org.eclipse.remote.ui" version="0.0.0"/> | ||
| <unit id="org.eclipse.remote.jsch.core" version="0.0.0"/> | ||
| <unit id="org.eclipse.remote.jsch.ui" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/tools/cdt/releases/12.4/cdt-12.4.0/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.eclipse.swtbot.eclipse.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.swtbot.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.swtbot.generator.feature.feature.group" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/technology/swtbot/releases/4.3.0/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="bcpg" version="0.0.0"/> | ||
| <unit id="bcprov" version="0.0.0"/> | ||
| <unit id="ch.qos.logback.classic" version="0.0.0"/> | ||
| <unit id="com.fasterxml.jackson.core.jackson-core" version="0.0.0"/> | ||
| <unit id="com.google.gson" version="0.0.0"/> | ||
| <unit id="com.google.guava" version="33.5.0.jre"/> | ||
| <unit id="jakarta.activation-api" version="1.2.2"/> | ||
| <unit id="jakarta.annotation-api" version="1.3.5"/> | ||
| <unit id="jakarta.el-api" version="5.0.1"/> | ||
| <unit id="jakarta.inject.jakarta.inject-api" version="1.0.5"/> | ||
| <unit id="jakarta.servlet.jsp-api" version="3.1.1"/> | ||
| <unit id="jakarta.xml.bind-api" version="2.3.3"/> | ||
| <unit id="json" version="0.0.0"/> | ||
| <unit id="org.antlr.runtime" version="3.2.0.v20230929-1400"/> | ||
| <unit id="org.antlr.runtime.source" version="3.2.0.v20230929-1400"/> | ||
| <unit id="org.apache.commons.cli" version="0.0.0"/> | ||
| <unit id="org.apache.commons.commons-compress" version="0.0.0"/> | ||
| <unit id="org.apache.commons.commons-io" version="0.0.0"/> | ||
| <unit id="org.apache.commons.commons-logging" version="0.0.0"/> | ||
| <unit id="org.apache.commons.lang3" version="0.0.0"/> | ||
| <unit id="org.apache.xml.serializer" version="0.0.0"/> | ||
| <unit id="org.mortbay.jasper.mortbay-apache-jsp" version="9.0.111"/> | ||
| <unit id="org.osgi.service.component.annotations" version="0.0.0"/> | ||
| <unit id="slf4j.api" version="0.0.0"/> | ||
| <unit id="slf4j.simple" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.39.0/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.mozilla.javascript" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.29.0/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.eclipse.license.feature.group" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/cbi/updates/license/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.eclipse.platform.ide" version="0.0.0"/> | ||
| <unit id="org.eclipse.equinox.executable.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.pde.runtime" version="0.0.0"/> | ||
| <unit id="org.eclipse.pde.junit.runtime" version="0.0.0"/> | ||
| <unit id="org.eclipse.equinox.p2.discovery.feature.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.equinox.p2.sdk.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.test.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.jdt.annotation" version="0.0.0"/> | ||
| <unit id="org.eclipse.jdt.core" version="0.0.0"/> | ||
| <unit id="org.eclipse.jdt.core.compiler.batch" version="0.0.0"/> | ||
| <unit id="org.eclipse.swt.tools.spies" version="0.0.0"/> | ||
| <unit id="org.eclipse.ui.trace" version="0.0.0"/> | ||
| <unit id="org.eclipse.ui.views.log" version="0.0.0"/> | ||
| <unit id="org.eclipse.jdt.junit4.runtime" version="0.0.0"/> | ||
| <unit id="org.eclipse.e4.ui.progress" version="0.0.0"/> | ||
| <unit id="org.eclipse.osgi.services" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/eclipse/updates/4.39/R-4.39-202602260420/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.eclipse.tracecompass.testtraces.tracecompass-test-traces-ctf" version="1.7.2"/> | ||
| <repository location="https://archive.eclipse.org/tracecompass/tracecompass-test-traces/repository/1.7.2/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.eclipse.wst.xml.core" version="0.0.0"/> | ||
| <unit id="org.eclipse.wst.xml.ui" version="0.0.0"/> | ||
| <unit id="org.eclipse.wst.xsd.core" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/webtools/downloads/drops/R3.41.0/R-3.41.0-20260225091541/repository/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.eclipse.emf.common.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.emf.ecore.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.xsd" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/modeling/emf/emf/builds/release/2.45.0/"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <unit id="org.eclipse.swtchart.feature.feature.group" version="0.0.0"/> | ||
| <unit id="org.eclipse.swtchart.feature.source.feature.group" version="0.0.0"/> | ||
| <repository location="https://download.eclipse.org/swtchart/releases/0.14.0/repository/"/> | ||
| </location> | ||
| <location includeDependencyDepth="infinite" includeDependencyScopes="provided,compile,system,runtime" includeSource="true" missingManifest="generate" type="Maven"> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.eclipse.tracecompass</groupId> | ||
| <artifactId>trace-event-logger</artifactId> | ||
| <version>0.5.1</version> | ||
| <type>jar</type> | ||
| </dependency> | ||
| </dependencies> | ||
| </location> | ||
| </locations> | ||
| <targetJRE path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/> | ||
| <launcherArgs> | ||
| <vmArgs>-Xms40m | ||
| -Xmx512M</vmArgs> | ||
| <programArgs>-consolelog</programArgs> | ||
| </launcherArgs> | ||
| </target> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if e4.39 target is registered in pom.xml
echo "=== Checking pom.xml for e4.39 artifact registration ==="
rg -n 'e4\.39' releng/org.eclipse.tracecompass.target/pom.xml
echo ""
echo "=== Current artifact registrations in pom.xml ==="
rg -A3 '<classifier>tracecompass-e' releng/org.eclipse.tracecompass.target/pom.xmlRepository: eclipse-tracecompass/org.eclipse.tracecompass
Length of output: 1495
Register the tracecompass-e4.39.target artifact in pom.xml.
Add the following artifact entry to releng/org.eclipse.tracecompass.target/pom.xml in the <artifacts> section:
XML snippet
<artifact>
<file>tracecompass-e4.39.target</file>
<type>target</type>
<classifier>tracecompass-e4.39</classifier>
</artifact>Without this registration, the e4.39 target will not be attached as a build artifact.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@releng/org.eclipse.tracecompass.target/tracecompass-e4.39.target` around
lines 1 - 114, Add a new artifact entry for the target file so the e4.39 target
is attached to the build: open the module pom.xml containing the <artifacts>
section and add an <artifact> element with
<file>tracecompass-e4.39.target</file>, <type>target</type> and
<classifier>tracecompass-e4.39</classifier>; ensure the new <artifact> sits
inside the existing <artifacts> container and the tag names match exactly so the
build system will publish the target file.
…feature version to 11.3.0 Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
What it does
How to test
Build with e4.37 or eStaging target with Eclipse 2026-03
Follow-ups
Review checklist
Summary by CodeRabbit