Switch writeFileReplacement to V2 Replacer#16815
Merged
JonasHelming merged 1 commit intomasterfrom Jan 12, 2026
Merged
Conversation
ndoschek
approved these changes
Jan 12, 2026
Member
ndoschek
left a comment
ndoschek
left a comment
There was a problem hiding this comment.
Thanks, LGTM 👍
I added a small nit, but I leave it up to you whether you want to address it.
| expect(jsonResponse.error).to.equal('Operation cancelled by user'); | ||
| }); | ||
|
|
||
| it('WriteFileReplacements should have correct ID', () => { |
Member
There was a problem hiding this comment.
Nit: this test does not add much value, since it effectively asserts the same static string constant twice, so I'd prefer removing it.
github-project-automation
Bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Use the V2 Replacer for "writeFileReplacement" function. The new replacer was already used for the "suggestFileReplacement" for quite a while and works more efficiently.
How to test
Use Theia Coder agent mode and observe the file replacement function calls. They should generally work. It will be hard to identify a difference while testing probably.
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers