feat: docs_bundle - #671
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
|
||
| docs_sources_env["ACTION"] = "incremental" | ||
| py_binary( | ||
| name = "docs_combo", |
There was a problem hiding this comment.
Moving too fast. Keep docs_combo for backwards-compatibility.
Co-authored-by: Maximilian Sören Pollak <maximilian.pollak@qorix.com>
| | ---------------------------------------------- | ------------------------------------------------------------------------------------------------- | | ||
| | `bazel run //:docs` | Builds documentation (also writes `metrics.json`) | | ||
| | `bazel run //:docs_check` | Verifies documentation correctness | | ||
| | `bazel run //:docs_combo` | Builds combined documentation with all external dependencies included | |
There was a problem hiding this comment.
Please avoid the breaking change of removing :docs_combo
There was a problem hiding this comment.
docs_combo only works in ref int, and we will add it there as an alias. We need to change BUILD file anyway.
|
Implemented in ef8b35d: removed the CodeQL-specific defensive-path layer while retaining the external-runfiles correction; restored needscfg_exclude_defaults = True; split the user documentation into a concise How-to and user-facing Concept; added a PlantUML diagram, DR-008-infra reference, and maintainer documentation next to score_mounts under Internals → Extensions → Mounts. Validation passed: full Bazel test suite (20/20), docs_check, HTML docs, and actionlint. Left open intentionally: entry_doc API decision, legacy docs_combo discussion, and remaining CodeQL alert threads. |
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
I have some questions but they are nitpicks nothing major.
They all can be fixed in future PR's.
From my side this is a good starting point that now can be added onto.
|
previously approved + all nit picks resolved. Need a new approval. |
Bundles!
📌 Description
🚨 Impact Analysis
✅ Checklist