Show unified diff for compare inputs that carry an ancestor#2789
Merged
vogella merged 1 commit intoJul 1, 2026
Conversation
canShowInUnifiedDiff rejected any ICompareInput with a common ancestor, which excluded EGit history compares (e.g. Compare With Previous Version) that attach a git merge-base ancestor. The overlay only renders left vs right, so the ancestor can be ignored.
Contributor
Author
|
It works from "Compare with -> Previous Revision". 
Without this patch: 
|
Contributor
Author
|
Also works now from the History view for files -> Compare with Previous version |
Contributor
tobiasmelcher
approved these changes
Jul 1, 2026
tobiasmelcher
left a comment
tobiasmelcher
left a comment
Contributor
There was a problem hiding this comment.
thanks a lot Lars.
Contributor
Author
Awesome feature thanks a bunch @tobiasmelcher for providing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experimental unified diff overlay was only offered for strict 2-way compare inputs, because
canShowInUnifiedDiffbailed out whenever the input carried a common ancestor.That excluded EGit history compares such as "Compare With Previous Version", which attach a git merge-base ancestor even for a conceptually 2-way diff.
Since the overlay is computed purely from the left and right sides, the ancestor can safely be ignored.
With this change those compares render inline diff markers when the experimental unified diff preference is enabled.