Apply the new popup menu icon to the loaded JFace icons/full copy#4147
Merged
vogella merged 1 commit intoJun 30, 2026
Merged
Conversation
JFaceResources registers POPUP_IMG_MENU with icons/full/popup_menu.svg as the primary resource and uses the class-relative dialogs/images copy only as a non-OSGi fallback, so the earlier swap that only touched dialogs/images was invisible inside a running Eclipse. Copy the three-dots artwork into icons/full so PopupDialogs such as Quick Access render the new glyph.
Contributor
Test Results 855 files ±0 855 suites ±0 1h 0m 31s ⏱️ +41s For more details on these failures, see this check. Results for commit 0c46b87. ± Comparison against base commit 358485b. |
Contributor
Author
|
Test failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JFaceResourcesregisters thePopupDialogmenu icon (POPUP_IMG_MENU) withicons/full/popup_menu.svgas the primary resource and only falls back to the class-relativedialogs/imagescopy when JFace runs outside OSGi. PR #4118 updated only thedialogs/imagescopy, so inside a running Eclipse the Quick Access dialog and otherPopupDialogs still showed the old blue chevron. This copies the new three-dots artwork (enabled and disabled, in png, @2x and svg) intoicons/fullso the icon is actually visible in the IDE. This completes the change started in #4118 for issue #4089.