Allow to ignore explicitly defined disabled icons#4002
Open
HeikoKlare wants to merge 1 commit into
Open
Conversation
The algorithm for generating disabled icons on-the-fly has recently been enhanced. Most explicit disabled icons that have been embedded into bundles conform to what now can be generated on-the-fly. In addition, the algorithm is interchangeable, allowing custom stylings of disabled icons. However, when there are still bundles, such as extensions out of own control, that still explicitly define disabled icons, exchanging the algorithm for disabled icons will lead to inconsistent appearance as only the on-the-fly generated icons will adhere to that. This change allows to ignore explicitly defined disabled icons, such that even if some bundles defined disabled icons, they will be ignored and on-the-fly generated disabled icons according to the selected algorithm will be used instead. An according preference that can be configured via the appearance tab is added.
HeikoKlare
force-pushed
the
ignore-disabled-icons
branch
from
29a2bec to
b8ed790
Compare
Contributor
HannesWell
approved these changes
May 14, 2026
Member
HannesWell
left a comment
HannesWell
left a comment
There was a problem hiding this comment.
Thanks for this. I think this totally makes sense and helps to fade out explicit/dedicated disabled icons.
I just have one suggestions for their label/description.
Comment on lines
+440
to
+441
| ViewsPreference_ignoreDisabledIcons = Ignore pre-generated disabled icons | ||
| ViewsPreference_ignoreDisabledIcons_tooltip = When enabled ignores pre-generated disabled icons in favor of generating consistently styled disabled icons on the fly |
Member
There was a problem hiding this comment.
What about labling these icons as explicit disabled icons or dedicated disabled icons?
Suggested change
| ViewsPreference_ignoreDisabledIcons = Ignore pre-generated disabled icons | |
| ViewsPreference_ignoreDisabledIcons_tooltip = When enabled ignores pre-generated disabled icons in favor of generating consistently styled disabled icons on the fly | |
| ViewsPreference_ignoreDisabledIcons = Ignore explicit disabled icons | |
| ViewsPreference_ignoreDisabledIcons_tooltip = When enabled ignores explicit disabled icons in favor of generating consistently styled disabled icons on the fly |
But I'm not sure if explicit could be read with other meaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows to ignore explicitly defined disabled icons (as SWT provides a proper way to do it on-the-fly since 2025-06) and enabled that behavior by default.
This is an extract of:
In that PR, no objections have been raised on always using the on-the-fly generation of disabled icons. I thus intend to merge this at the beginning of 4.41 development in case no objections are raised until then.
@HannesWell we had discussed the extraction of this rather non-controversial change offline. Maybe you want to have a quick a look.
Description
The algorithm for generating disabled icons on-the-fly has recently been enhanced. Most explicit disabled icons that have been embedded into bundles conform to what now can be generated on-the-fly. In addition, the algorithm is interchangeable, allowing custom stylings of disabled icons. However, when there are still bundles, such as extensions out of our control, that still explicitly define disabled icons, exchanging the algorithm for disabled icons will lead to inconsistent appearance as only the on-the-fly generated icons will adhere to that.
This change allows to ignore explicitly defined disabled icons, such that even if some bundles defined disabled icons, they will be ignored and on-the-fly generated disabled icons according to the selected algorithm will be used instead. An according preference that can be configured via the appearance tab is added.
How to test
The enhancement is configurable via preference, thus can be tested by enabling/disabling it:
As an example, this is what the main toolbar looks like with different configurations:
Existing
No pregenerated disabled icons