Skip to content

Incorrect Colors in LTK Refactoring Preview Wizard#3777

Open
iloveeclipse wants to merge 2 commits intoeclipse-platform:masterfrom
iloveeclipse:issue_3776
Open

Incorrect Colors in LTK Refactoring Preview Wizard#3777
iloveeclipse wants to merge 2 commits intoeclipse-platform:masterfrom
iloveeclipse:issue_3776

Conversation

@iloveeclipse
Copy link
Member

Change left/right diff elements in refactoring wizard to get proper diff coloring.

This would make the "diff order" consistent with the current Eclipse diff order, which is, let say, "unusual" for a very long time (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=213780). That is also the reason the refactoring wizard had always "swapped" the input sides, being inconsistent to provide expected usability. However the coloring can be consistent only if the diff order is default one, and since diff coloring was added, refactoring wizard "hack" became visible.

See also #3776.

This PR depends on eclipse-platform/eclipse.platform#2566 to avoid unexpected change of the "usual" diff order in the refactoring wizard.

Fixes #3775

iloveeclipse and others added 2 commits March 13, 2026 15:47
Change left/right diff elements in refactoring wizard to get proper diff
coloring.

This would make the "diff order" consistent with the **current** Eclipse
diff order, which is, let say, "unusual" for a very long time (see
https://bugs.eclipse.org/bugs/show_bug.cgi?id=213780).  That is also the
reason the refactoring wizard had always "swapped" the input sides,
being inconsistent to provide expected usability. However the coloring
can be consistent only if the diff order is default one, and since diff
coloring was added, refactoring wizard "hack" became visible.

See also eclipse-platform#3776.

This PR depends on
eclipse-platform/eclipse.platform#2566 to avoid
unexpected change of the "usual" diff order in the refactoring wizard.

Fixes eclipse-platform#3775
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 68b3126867d2835dae62476b4744a77bb582a06f Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 13 Mar 2026 14:54:28 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF b/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
index ce0e45e0d3..dea006509a 100644
--- a/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ltk.ui.refactoring/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.ltk.ui.refactoring
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ltk.ui.refactoring; singleton:=true
-Bundle-Version: 3.14.0.qualifier
+Bundle-Version: 3.14.100.qualifier
 Bundle-Activator: org.eclipse.ltk.internal.ui.refactoring.RefactoringUIPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

Test Results

   852 files   - 2 058     852 suites   - 2 058   58m 37s ⏱️ - 1h 3m 27s
 7 848 tests +  140   7 605 ✅ +  145  243 💤  -   5  0 ❌ ±0 
20 070 runs   - 1 878  19 414 ✅  - 1 739  656 💤  - 139  0 ❌ ±0 

Results for commit 7f2ea20. ± Comparison against base commit ae64c28.

This pull request removes 5800 and adds 5940 tests. Note that renamed tests count towards both.
AllFormsTests AllEventsTests ExpansionListenerTest ‑ callsExpansionStateChangedConsumer
AllFormsTests AllEventsTests ExpansionListenerTest ‑ callsExpansionStateChangingConsumer
AllFormsTests AllEventsTests ExpansionListenerTest ‑ throwsNullPointerOnNullStateChangedAdapter
AllFormsTests AllEventsTests ExpansionListenerTest ‑ throwsNullPointerOnNullStateChangingAdapter
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ callsActivatedConsumer
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ callsEnteredConsumer
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ callsExitedConsumer
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ throwsNullPointerOnNullActivatedAdapter
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ throwsNullPointerOnNullEnteredAdapter
AllFormsTests AllEventsTests HyperLinkListenerTest ‑ throwsNullPointerOnNullExitedAdapter
…
UiTestSuite ‑ Unknown test
org.eclipse.core.filebuffers.tests.ConvertLineDelemiterTest ‑ testWithDelimnAtEnd
org.eclipse.core.filebuffers.tests.ConvertLineDelemiterTest ‑ testWithoutDelimnAtEnd
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test1
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test1_IFILE
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test1_IFileStore
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test2
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test2_new
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test3_1
org.eclipse.core.filebuffers.tests.FileBufferCreation ‑ test3_1_IFILE
…
This pull request removes 119 skipped tests and adds 119 skipped tests. Note that renamed tests count towards both.
AllSearchTests AllFileSearchTests SearchResultPageTest ‑ testBasicDisplay
AllSearchTests AllFileSearchTests SearchResultPageTest ‑ testRemoveTreeMatches
AllTests FieldAssistTestSuite ControlDecorationTests ‑ testBug418420
EclipseTextTestSuite FindReplaceDocumentAdapterTest ‑ _testRegexFindLinebreak2
EclipseTextTestSuite FindReplaceDocumentAdapterTest ‑ _testRegexReplace
JFaceTextTestSuite FilteringAsyncContentAssistTests ‑ testFastCompletionsNotFilteredUntilLongComplitionsCalculated
JFaceTextTestSuite MultiSelectionTest ‑ testViewer
NavigatorTestSuite FoldersAsProjectsContributionTest ‑ alreadyAdded
NavigatorTestSuite FoldersAsProjectsContributionTest ‑ notYetImported
RcpTestSuite PlatformUITest ‑ testCreateAndRunWorkbenchWithExceptionOnStartup
…
UiTestSuite ‑ Unknown test
org.eclipse.e4.ui.tests.workbench.MWindowTest ‑ TODOtestWindow_X
org.eclipse.e4.ui.tests.workbench.MWindowTest ‑ TODOtestWindow_Y
org.eclipse.e4.ui.tests.workbench.ModelAssemblerTests ‑ testFragments_existingXMIID_checkExists
org.eclipse.e4.ui.tests.workbench.PartRenderingEngineTests ‑ TODOtestBug326175_True
org.eclipse.e4.ui.workbench.renderers.swt.MenuManagerRendererTest ‑ testMMenu_ToBeRendered
org.eclipse.jface.tests.fieldassist.ControlDecorationTests ‑ testBug418420
org.eclipse.jface.text.tests.MultiSelectionTest ‑ testViewer
org.eclipse.jface.text.tests.contentassist.FilteringAsyncContentAssistTests ‑ testFastCompletionsNotFilteredUntilLongComplitionsCalculated
org.eclipse.search.tests.filesearch.SearchResultPageTest ‑ testBasicDisplay
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect Colors in LTK Refactoring Preview Wizard

2 participants